[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: KDev-PG-Qt and unions
From:       "Jonathan =?iso-8859-1?q?Schmidt-Domin=E9_-?= Developer"
Date:       2010-04-24 16:08:05
Message-ID: 201004242005.51173.devel () the-user ! org
[Download RAW message or body]

Hi Milian!

A DefaultVisitor would work well without any flags, but have had a look at the 
PHP-plugin, duchain/expressionvisitor.cpp:
Line 214: if(node->stringFunctionName)
Line 236: else if(node->varFunctionName)
php.g, lines 549 and 550:
stringFunctionName=identifier ... | varFunctionName=variableWithoutObjects
There would probably be a union { IdentifierAst *stringFunctionName; 
VariableWithoutObjectsAst *varFunctionName; }; the current code in 
expressionvisitor.cpp would not work any longer.
I agree that most stuff in the php-plugin does not need such information, but 
KDev-PG-Qt can not rely on that. In some cases the mentioned inline-methods 
could also be implemented without any additional bits, but not always...

Jonathan

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]