[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: DVCS plugin interface
From:       Fabian Wiesel <fabian.wiesel () googlemail ! com>
Date:       2009-06-23 16:14:07
Message-ID: f9f8f8fd0906230914ua559afdj32b6f39f6ed0670 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


2009/6/23 Fabian Wiesel <fabian.wiesel@googlemail.com>

>
>
> 2009/6/21 Hugo Parente Lima <hugo.pl@gmail.com>
>
>>
>> Yeah, the kdevplatform/vcs/dvcs/ui uses it; but nobody uses
>> kdevplatform/vcs/dvcs/ui,
>
>
> That is not quite correct. It is called via
> ctxRevHistory() -> getAllCommits() -> parseLogOutput(). After that, it gets
> displayed in CommitView, which is part of vcs/dvcs/gui.
> But since the call is routed via
> DistributedVersionControlPlugin::getAllCommits(), which is already pure
> virtual, it doesn't have to stay.
>

I meant the pure virtual parseLogOutput() function in
DistributedVersionControlPlugin.

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">2009/6/23 Fabian Wiesel <span dir="ltr">&lt;<a \
href="mailto:fabian.wiesel@googlemail.com">fabian.wiesel@googlemail.com</a>&gt;</span><br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> <br><br><div class="gmail_quote">2009/6/21 Hugo \
Parente Lima <span dir="ltr">&lt;<a href="mailto:hugo.pl@gmail.com" \
target="_blank">hugo.pl@gmail.com</a>&gt;</span><div class="im"><br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;">

<div><br>
</div>Yeah, the kdevplatform/vcs/dvcs/ui uses it; but nobody uses<br>
kdevplatform/vcs/dvcs/ui, </blockquote></div><div><br>That is not quite correct. It \
is called via<br>ctxRevHistory() -&gt; getAllCommits() -&gt; parseLogOutput(). After \
that, it gets displayed in CommitView, which is part of vcs/dvcs/gui.<br>

But since the call is routed via DistributedVersionControlPlugin::getAllCommits(), \
which is already pure virtual, it doesn&#39;t have to \
stay.</div></div></blockquote><div>  </div></div>I meant the pure virtual \
parseLogOutput() function in DistributedVersionControlPlugin.<br> <br>



_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]