[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: DVCS plugin interface
From: Fabian Wiesel <fabian.wiesel () googlemail ! com>
Date: 2009-06-23 16:12:17
Message-ID: f9f8f8fd0906230912t2ae6f43fl9b74425cbbe13e6e () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
2009/6/21 Hugo Parente Lima <hugo.pl@gmail.com>
>
> Yeah, the kdevplatform/vcs/dvcs/ui uses it; but nobody uses
> kdevplatform/vcs/dvcs/ui,
That is not quite correct. It is called via
ctxRevHistory() -> getAllCommits() -> parseLogOutput(). After that, it gets
displayed in CommitView, which is part of vcs/dvcs/gui.
But since the call is routed via
DistributedVersionControlPlugin::getAllCommits(), which is already pure
virtual, it doesn't have to stay.
and somethings in kdevplatform/vcs/dvcs are
> redundant, because are already implemented in vcs plugins infrastructure
>
Mainly things relating to the repository history/log. You certainly can
consider DVcsEvent a generalisation of VcsEvent, because it allows several
parent revisions.
This is also why the GUI displaying it (CommitView) is largely duplicated
functionality.
> > From kdevplatform/vcs/dvcs/ui I think that just the branch manager is
> > used... and (I hope) the importmetadata widget. Some things like log
> > view, commit view are redundant and IMO should use the code used in VCS
> > plugins.
The equivalent of CommitView in VCS isn't capable of displaying the Directed
Acyclic Graph of the commits. So, unless the generic-part gains that neet
feature, I'd rather keep it.
LogView, on the other hand, is not only redundant, but also unused. If no
one objects, I could remove it.
Fabian
[Attachment #5 (text/html)]
<br><br><div class="gmail_quote">2009/6/21 Hugo Parente Lima <span dir="ltr"><<a \
href="mailto:hugo.pl@gmail.com">hugo.pl@gmail.com</a>></span><br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> <div class="im"><br>
</div>Yeah, the kdevplatform/vcs/dvcs/ui uses it; but nobody uses<br>
kdevplatform/vcs/dvcs/ui, </blockquote><div><br>That is not quite correct. It is \
called via<br>ctxRevHistory() -> getAllCommits() -> parseLogOutput(). After \
that, it gets displayed in CommitView, which is part of vcs/dvcs/gui.<br> But since \
the call is routed via DistributedVersionControlPlugin::getAllCommits(), which is \
already pure virtual, it doesn't have to stay.<br><br></div><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> and somethings in kdevplatform/vcs/dvcs are<br>
redundant, because are already implemented in vcs plugins infrastructure<br>
<div class="im"></div></blockquote><div class="im"><br>Mainly things relating to the \
repository history/log. You certainly can consider DVcsEvent a generalisation of \
VcsEvent, because it allows several parent revisions.<br> This is also why the GUI \
displaying it (CommitView) is largely duplicated functionality.<br><br> > > \
From kdevplatform/vcs/dvcs/ui I think that just the branch manager is<br> > > \
used... and (I hope) the importmetadata widget. Some things like log<br> > > \
view, commit view are redundant and IMO should use the code used in VCS<br> > > \
plugins.<br><br>The equivalent of CommitView in VCS isn't capable of displaying \
the Directed Acyclic Graph of the commits. So, unless the generic-part gains that \
neet feature, I'd rather keep it.<br>LogView, on the other hand, is not only \
redundant, but also unused. If no one objects, I could remove it.<br> \
</div></div><br>Fabian<br><br>
_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic