[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    cppcodecompletion reorganization
From:       Andras Mantia <amantia () kde ! org>
Date:       2006-05-26 22:00:12
Message-ID: 200605270100.12449.amantia () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Hi,

 I think I will stop now with reorganizing this code. I'm sure it can be 
done much more, but now at least it is partly separated, rearranged, 
and hopefully it is more readable. Still I would request David to make 
some more steps:

- fix the copyright headers
- fix the warnings. There are many "unused" parameter warnings. If you 
don't need them, remove them. If they are needed in some instance (like 
in the super class, but not the derivate one) use Q_UNUSED(variable). 
There are also many "unhandled enum value" warnings.
- remove unused methods and functions. Don't keep them because "they 
might be needed". This is not a library, so you can safely add later 
anything without worrying of BC issues.

The above I would say is a must. Some extra ideas what to do:
- move out the remaining classes from  cppcodecompletion (I think there 
are two now)
- split simpletype.h/cpp more
- create an implementation file for computerecoverypoints
- be sure to keep inline methods only those that are: 
	- very simple (return a member variable, for example)
	- are performance critical  
- reduce the number of typedef's, friend classes and class-inside-class 
constructions.
- verify the header dependencies and reduce them to minimal (can be done 
if you have less inline methods)
- document the methods and classes with doxygen tags

Andras


-- 
Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@barney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]