--===============0260196169==
Content-Type: multipart/signed;
  boundary="nextPart1163418.EKyWnQaoVB";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart1163418.EKyWnQaoVB
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hi,

 I think I will stop now with reorganizing this code. I'm sure it can be=20
done much more, but now at least it is partly separated, rearranged,=20
and hopefully it is more readable. Still I would request David to make=20
some more steps:

=2D fix the copyright headers
=2D fix the warnings. There are many "unused" parameter warnings. If you=20
don't need them, remove them. If they are needed in some instance (like=20
in the super class, but not the derivate one) use Q_UNUSED(variable).=20
There are also many "unhandled enum value" warnings.
=2D remove unused methods and functions. Don't keep them because "they=20
might be needed". This is not a library, so you can safely add later=20
anything without worrying of BC issues.

The above I would say is a must. Some extra ideas what to do:
=2D move out the remaining classes from  cppcodecompletion (I think there=20
are two now)
=2D split simpletype.h/cpp more
=2D create an implementation file for computerecoverypoints
=2D be sure to keep inline methods only those that are:=20
	- very simple (return a member variable, for example)
	- are performance critical =20
=2D reduce the number of typedef's, friend classes and class-inside-class=20
constructions.
=2D verify the header dependencies and reduce them to minimal (can be done=
=20
if you have less inline methods)
=2D document the methods and classes with doxygen tags

Andras


=2D-=20
Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org

--nextPart1163418.EKyWnQaoVB
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQBEd3psTQdfac6L/08RAsGOAKCgKMvPxLUszk2zIXtTWUV0+yfrrQCgsMOK
ON3s7lJMfZdd+UjcjAFctmo=
=RnWX
-----END PGP SIGNATURE-----

--nextPart1163418.EKyWnQaoVB--


--===============0260196169==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDevelop-devel mailing list
KDevelop-devel@barney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

--===============0260196169==--