[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-windows
Subject:    Re: [patch] add option for disabling kwinstartmenu
From:       Ralf Habacker <ralf.habacker () freenet ! de>
Date:       2008-04-16 6:22:01
Message-ID: 48059B09.7080106 () freenet ! de
[Download RAW message or body]

Jarosław Staniek schrieb:
> for review,
> 
+    KConfigGroup group( &d->config, "General" );
+    if (!group.readEntry("Enabled", true))
+      return;
+

returning immediatly in the constructor disables the dbus interface which is \
initiated later 

Would it not be better in case of menu creating disabled not to call the following \
connect (and disconnect on destruction) ? 

    connect(d->ksycoca, SIGNAL(databaseChanged()), this, SLOT(databaseChanged()));

Ralf 



_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows


[prev in list] [next in list] [prev in thread] [next in thread]