From kde-windows  Wed Apr 16 06:22:01 2008
From: Ralf Habacker <ralf.habacker () freenet ! de>
Date: Wed, 16 Apr 2008 06:22:01 +0000
To: kde-windows
Subject: Re: [patch] add option for disabling kwinstartmenu
Message-Id: <48059B09.7080106 () freenet ! de>
X-MARC-Message: https://marc.info/?l=kde-windows&m=120832690814976

Jarosław Staniek schrieb:
> for review,
>
+    KConfigGroup group( &d->config, "General" );
+    if (!group.readEntry("Enabled", true))
+      return;
+

returning immediatly in the constructor disables the dbus interface which is initiated later 

Would it not be better in case of menu creating disabled not to call the following connect (and disconnect on destruction) ? 

    connect(d->ksycoca, SIGNAL(databaseChanged()), this, SLOT(databaseChanged()));

Ralf 



_______________________________________________
Kde-windows mailing list
Kde-windows@kde.org
https://mail.kde.org/mailman/listinfo/kde-windows