[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 128032: Fix command line argument handling
From: Urs Wolfer <uwolfer () kde ! org>
Date: 2016-07-21 19:35:50
Message-ID: 20160721193550.4909.25768 () mimi ! kde ! org
[Download RAW message or body]
--===============8163893897856742219==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128032/#review97724
-----------------------------------------------------------
Finally, I have submitted your fixes. Thanks again for your work. \
(https://quickgit.kde.org/?p=krdc.git)
I think this change can be abandoned since things are included in the other changes?
- Urs Wolfer
On May 29, 2016, 10:34 a.m., Arno Möller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128032/
> -----------------------------------------------------------
>
> (Updated May 29, 2016, 10:34 a.m.)
>
>
> Review request for KDE Utils and Urs Wolfer.
>
>
> Repository: krdc
>
>
> Description
> -------
>
> * Use QUrl::fromUserInput() for parsing command line arguments
> * Bail out MainWindow::newConnection() if we don't have a plugin for the requested \
> URL
> * Ignore the return value from showDialogIfNeeded(). Since we're already there, the \
> user made quite clear that he wants to see the view, either by passing it via the \
> command line or typing it into the new connection bar.
>
> Diffs
> -----
>
> main.cpp 73093f3
> mainwindow.cpp dd1d8a0
>
> Diff: https://git.reviewboard.kde.org/r/128032/diff/
>
>
> Testing
> -------
>
> Invoke:
> $ krdc rdp://<your.favorite.rdp.host>
>
> Without the 1. patch krdc converts the URL to vnc:// as seen in the windowTitle.
> With the 1. patch, but without the 2., the RDP connection is opened, but the view \
> is closed instantly by MainWindow::saveHostPrefs(), leaving the user with a new \
> connection tab. With both patches krdc works as expected.
>
>
> Thanks,
>
> Arno Möller
>
>
--===============8163893897856742219==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128032/">https://git.reviewboard.kde.org/r/128032/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Finally, I have submitted your fixes. Thanks again for your work. \
(https://quickgit.kde.org/?p=krdc.git)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I think this change can \
be abandoned since things are included in the other changes?</p></pre> <br />
<p>- Urs Wolfer</p>
<br />
<p>On May 29th, 2016, 10:34 a.m. UTC, Arno Möller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Utils and Urs Wolfer.</div>
<div>By Arno Möller.</div>
<p style="color: grey;"><i>Updated May 29, 2016, 10:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
krdc
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Use \
QUrl::fromUserInput() for parsing command line arguments</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Bail \
out MainWindow::newConnection() if we don't have a plugin for the requested URL</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Ignore the return value from showDialogIfNeeded(). \
Since we're already there, the user made quite clear that he wants to see the view, \
either by passing it via the command line or typing it into the new connection \
bar.</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Invoke: $ krdc \
rdp://<your.favorite.rdp.host></p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Without the 1. patch \
krdc converts the URL to vnc:// as seen in the windowTitle. With the 1. patch, but \
without the 2., the RDP connection is opened, but the view is closed instantly by \
MainWindow::saveHostPrefs(), leaving the user with a new connection tab. With both \
patches krdc works as expected.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>main.cpp <span style="color: grey">(73093f3)</span></li>
<li>mainwindow.cpp <span style="color: grey">(dd1d8a0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128032/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8163893897856742219==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic