From kde-utils-devel Thu Jul 21 19:35:50 2016 From: Urs Wolfer Date: Thu, 21 Jul 2016 19:35:50 +0000 To: kde-utils-devel Subject: Re: Review Request 128032: Fix command line argument handling Message-Id: <20160721193550.4909.25768 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-utils-devel&m=146912976522977 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2893413088894174143==" --===============2893413088894174143== Content-Type: multipart/alternative; boundary="===============8163893897856742219==" --===============8163893897856742219== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128032/#review97724 ----------------------------------------------------------- Finally, I have submitted your fixes. Thanks again for your work. (https://quickgit.kde.org/?p=krdc.git) I think this change can be abandoned since things are included in the other changes? - Urs Wolfer On May 29, 2016, 10:34 a.m., Arno Möller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128032/ > ----------------------------------------------------------- > > (Updated May 29, 2016, 10:34 a.m.) > > > Review request for KDE Utils and Urs Wolfer. > > > Repository: krdc > > > Description > ------- > > * Use QUrl::fromUserInput() for parsing command line arguments > * Bail out MainWindow::newConnection() if we don't have a plugin for the requested URL > * Ignore the return value from showDialogIfNeeded(). Since we're already there, the user made quite clear that he wants to see the view, either by passing it via the command line or typing it into the new connection bar. > > > Diffs > ----- > > main.cpp 73093f3 > mainwindow.cpp dd1d8a0 > > Diff: https://git.reviewboard.kde.org/r/128032/diff/ > > > Testing > ------- > > Invoke: > $ krdc rdp:// > > Without the 1. patch krdc converts the URL to vnc:// as seen in the windowTitle. > With the 1. patch, but without the 2., the RDP connection is opened, but the view is closed instantly by MainWindow::saveHostPrefs(), leaving the user with a new connection tab. > With both patches krdc works as expected. > > > Thanks, > > Arno Möller > > --===============8163893897856742219== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128032/

Finally, I have submitted your fixes. Thanks again for your work. (https://quickgit.kde.org/?p=krdc.git)

I think this change can be abandoned since things are included in the other changes?

- Urs Wolfer

On May 29th, 2016, 10:34 a.m. UTC, Arno Möller wrote:

Review request for KDE Utils and Urs Wolfer.

By Arno Möller.

Updated May 29, 2016, 10:34 a.m.

Repository: krdc

Description


Use QUrl::fromUserInput() for parsing command line arguments
Bail out MainWindow::newConnection() if we don't have a plugin for the requested URL
Ignore the return value from showDialogIfNeeded(). Since we're already there, the user made quite clear that he wants to see the view, either by passing it via the command line or typing it into the new connection bar.

Testing

Invoke: $ krdc rdp://<your.favorite.rdp.host>

Without the 1. patch krdc converts the URL to vnc:// as seen in the windowTitle. With the 1. patch, but without the 2., the RDP connection is opened, but the view is closed instantly by MainWindow::saveHostPrefs(), leaving the user with a new connection tab. With both patches krdc works as expected.

Diffs

main.cpp (73093f3)
mainwindow.cpp (dd1d8a0)

--===============8163893897856742219==-- --===============2893413088894174143== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLXV0aWxz LWRldmVsIG1haWxpbmcgbGlzdApLZGUtdXRpbHMtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwu a2RlLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2tkZS11dGlscy1kZXZlbAo= --===============2893413088894174143==--