[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-utils-devel
Subject:    [Differential] [Requested Changes To] D1821: Add support for LZ4-compressed tar archives
From:       "elvisangelaccio (Elvis Angelaccio)" <noreply () phabricator ! kde ! org>
Date:       2016-06-13 11:15:53
Message-ID: 20160613111551.81413.31654.8C927F13 () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:9
> 
> +if(LibArchive_FOUND)
> +  if(LibArchive_VERSION VERSION_EQUAL "3.2.0" OR

This `if()` is always going to be true, since libarchive is a required dep. So you \
can drop  it (same for all the `if()`s below)

> CMakeLists.txt:79
> +     LibArchive_VERSION VERSION_GREATER "3.2.0")
> +    target_compile_definitions(kerfuffle_libarchive PRIVATE \
> -DHAVE_LIBARCHIVE_3_2_0) +  endif()

This can be moved in the previous if().

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D1821

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara


[Attachment #5 (text/html)]

<table><tr><td style="">elvisangelaccio requested changes to this revision.<br \
/>elvisangelaccio added inline comments.<br />This revision now requires changes to \
proceed.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D1821" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1821#inline-7119" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:9</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">if(LibArchive_FOUND) </div><div style="padding: 0 8px; margin: \
0 4px; background: #d0ffd0;">  if(LibArchive_VERSION VERSION_EQUAL &quot;3.2.0&quot; \
OR </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
<tt style="background: #ebebeb; font-size: 13px;">if()</tt> is always going to be \
true, since libarchive is a required dep. So you can drop  it (same for all the <tt \
style="background: #ebebeb; font-size: 13px;">if()</tt>s below)</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1821#inline-7120" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:79</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">     LibArchive_VERSION VERSION_GREATER &quot;3.2.0&quot;) \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    \
target_compile_definitions(kerfuffle_libarchive PRIVATE -DHAVE_LIBARCHIVE_3_2_0) \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">  endif() \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">This can be moved in the previous \
if().</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rARK Ark</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1821" \
rel="noreferrer">https://phabricator.kde.org/D1821</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>rthomsen, elvisangelaccio<br /><strong>Cc: \
</strong>kde-utils-devel, tctara<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel


[prev in list] [next in list] [prev in thread] [next in thread]