[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Requested Changes To] D1841: Tasks model: don't load 4 icon sizes to then just use o
From: "hein (Eike Hein)" <noreply () phabricator ! kde ! org>
Date: 2016-06-13 11:04:07
Message-ID: 20160613110404.19931.98541.B8938F96 () phabricator ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
hein requested changes to this revision.
hein added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dfaure wrote in xwindowtasksmodel.cpp:662
> No clue, this "fixme" was already there, I'm only optimizing for speed. I'll let \
> Eike reply to this.
64 is the value from the old lib. Improving this is on my todo, but it's not a \
regression and I don't have time for it under the current schedule.
> xwindowtasksmodel.cpp:665
> + QPixmap pixmap;
> + const AppData &app = appData(window);
> + if (!app.icon.isNull()) {
Why not use the one from line 654?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1841
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dfaure, hein
Cc: broulik, plasma-devel, sebas
[Attachment #5 (text/html)]
<table><tr><td style="">hein requested changes to this revision.<br />hein added \
inline comments.<br />This revision now requires changes to proceed.</td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1841" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1841#inline-7114" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">dfaure</span> wrote in \
<span style="color: #4b4d51; font-weight: \
bold;">xwindowtasksmodel.cpp:662</span></div> <div style="margin: 8px 0; padding: 0 \
12px; color: #74777D;"><p style="padding: 0; margin: 8px;">No clue, this \
"fixme" was already there, I'm only optimizing for speed. I'll \
let Eike reply to this.</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">64 is the value from the old lib. \
Improving this is on my todo, but it's not a regression and I don't have \
time for it under the current schedule.</p></div></div><br /><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1841#inline-7116" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">xwindowtasksmodel.cpp:665</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #ffd0d0;"> <span class="bright"></span><span \
style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> \
</span><span class="p"><span class="bright">(</span></span><span \
class="bright"></span><span class="n"><span class="bright">i</span></span><span \
class="bright"></span><span class="p"><span class="bright">.</span></span><span \
class="bright"></span><span class="n"><span class="bright">isNull</span></span><span \
class="bright"></span><span class="p"><span class="bright">())</span></span><span \
class="bright"> </span><span class="p"><span class="bright">{</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
class="bright"></span><span class="n"><span class="bright">QPixmap</span></span><span \
class="bright"> </span><span class="n"><span class="bright">pixmap</span></span><span \
class="bright"></span><span class="p"><span class="bright">;</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: \
#aa4000">const</span> <span class="n">AppData</span> <span style="color: \
#aa2211">&</span><span class="n">app</span> <span style="color: #aa2211">=</span> \
<span class="n">appData</span><span class="p">(</span><span \
class="n">window</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span style="color: #aa4000">if</span> <span \
class="p">(</span><span style="color: #aa2211">!</span><span \
class="n">app</span><span class="p">.</span><span class="n">icon</span><span \
class="p">.</span><span class="n">isNull</span><span class="p">())</span> <span \
class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why \
not use the one from line 654?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1841" \
rel="noreferrer">https://phabricator.kde.org/D1841</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>dfaure, hein<br /><strong>Cc: </strong>broulik, \
plasma-devel, sebas<br /></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic