[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 120484: Small changes in Ark service menu strings
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2015-07-22 12:25:14
Message-ID: 20150722122514.23987.48303 () mimi ! kde ! org
[Download RAW message or body]
--===============5779503002289748028==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120484/#review68797
-----------------------------------------------------------
Ship it!
Looks sane to me. If you're still in doubt you can contact the usability folks, but \
IMHO we're good to go.
- Raphael Kubo da Costa
On June 11, 2015, 9:02 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120484/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 9:02 p.m.)
>
>
> Review request for KDE Utils and Raphael Kubo da Costa.
>
>
> Bugs: 198227
> http://bugs.kde.org/show_bug.cgi?id=198227
>
>
> Repository: ark
>
>
> Description
> -------
>
> The bug 198227 has a couple of points still not addressed.
> In the Ark service menu, the string `Compress To...` might be changed to `Compress \
> to...`. The other point was to change the string `Here` to `Here (as TAR.GZ)`, and \
> while I did it in this review, I think this needs to be discussed here.
> The fact: currently Ark has two desktop actions with different names but the same \
> effect: `Compress -> Here` and `Compress -> As TAR.GZ Archive`, i.e. the effect is \
> a tar.gz archive being created. I see four options:
> 1. Change the action `Here` to `Here (as TAR.GZ)`. In this way the novice user will \
> still see the word *here*, while the advanced user will know which archive format \
> is going to be used. But in this case the action `Compress -> As TAR.GZ Archive` \
> would become a duplicate both in the name (well, kind of) and in the effect. In \
> other words, the users will be confused about which of the two actions to choose. \
> 2. Change the action `Here` to `Here (as TAR.GZ)` and remove the action `Compress \
> -> As TAR.GZ Archive`. Now there are no duplicates and no confusion. 3. Remove the \
> action `Here`. No more duplicates and no more confusion, but now the novice user \
> will not see the word *here* (assuming that this was the reason why the `Here` \
> action has been created). 4. Stick with `Here` and `Compress -> As TAR.GZ Archive`, \
> so different names but same effect. If so, the bug should be closed, except maybe \
> for `Compress To...` becoming `Compress to...`
> So, I would go with 2. (this means I'd need to update the diff)
> What do you guys think?
>
>
> Diffs
> -----
>
> app/ark_addtoservicemenu.desktop 85ae4106870b83a50967ee99bc49779d788f924a
>
> Diff: https://git.reviewboard.kde.org/r/120484/diff/
>
>
> Testing
> -------
>
> Compile and check if the strings are changed.
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
--===============5779503002289748028==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120484/">https://git.reviewboard.kde.org/r/120484/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
sane to me. If you're still in doubt you can contact the usability folks, but IMHO \
we're good to go.</p></pre> <br />
<p>- Raphael Kubo da Costa</p>
<br />
<p>On June 11th, 2015, 9:02 p.m. EEST, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated June 11, 2015, 9:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=198227">198227</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The bug 198227 has a couple of points still not \
addressed. In the Ark service menu, the string <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Compress To...</code> might be changed to <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Compress to...</code>. The other point was to change the string <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">Here</code> to <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Here (as \
TAR.GZ)</code>, and while I did it in this review, I think this needs to be discussed \
here.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The fact: currently Ark has two desktop actions with \
different names but the same effect: <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Compress \
-> Here</code> and <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">Compress -> As TAR.GZ \
Archive</code>, i.e. the effect is a tar.gz archive being created. I see four \
options:</p> <ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Change the action <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">Here</code> to <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Here (as \
TAR.GZ)</code>. In this way the novice user will still see the word <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">here</em>, while the advanced user will know which archive format is going \
to be used. But in this case the action <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Compress \
-> As TAR.GZ Archive</code> would become a duplicate both in the name (well, kind \
of) and in the effect. In other words, the users will be confused about which of the \
two actions to choose.</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Change the action <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">Here</code> to <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Here (as \
TAR.GZ)</code> and remove the action <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Compress \
-> As TAR.GZ Archive</code>. Now there are no duplicates and no confusion.</li> \
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Remove the action <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Here</code>. No more duplicates and no more confusion, but now the novice \
user will not see the word <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">here</em> (assuming that this was the \
reason why the <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">Here</code> action has been \
created).</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Stick with <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Here</code> \
and <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">Compress -> As TAR.GZ Archive</code>, so \
different names but same effect. If so, the bug should be closed, except maybe for \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">Compress To...</code> becoming <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">Compress to...</code></li> </ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So, I would go with 2. (this means I'd need to update \
the diff) What do you guys think?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compile and check if the strings are \
changed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/ark_addtoservicemenu.desktop <span style="color: \
grey">(85ae4106870b83a50967ee99bc49779d788f924a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120484/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5779503002289748028==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic