[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request 120204: Create password-protected archives with Ark
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2015-07-22 12:12:14
Message-ID: 20150722121214.23987.57708 () mimi ! kde ! org
[Download RAW message or body]
--===============0745779497735319400==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120204/#review82803
-----------------------------------------------------------
Ship it!
\o/
Thanks a lot!
- Raphael Kubo da Costa
On July 22, 2015, 2:13 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120204/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 2:13 p.m.)
>
>
> Review request for KDE Utils and Raphael Kubo da Costa.
>
>
> Bugs: 253694
> http://bugs.kde.org/show_bug.cgi?id=253694
>
>
> Repository: ark
>
>
> Description
> -------
>
> This patch allows the users to create password-protected archives using Ark.
> The supported plugins are `zip`, `7z` and `rar`.
> The input fields for the passwords are displayed only when the relevent mime \
> filters are selected in the `AddDialog` window.
>
> Diffs
> -----
>
> app/mainwindow.cpp 6511d548e0657f670c3823f63b13c4ca4fa98036
> kerfuffle/CMakeLists.txt 8d118033571b447f6ce09140417f25abcf9d2f79
> kerfuffle/adddialog.h 217da1e44d19d869f052aaeab640000a4ea4051c
> kerfuffle/adddialog.cpp 45aed46404a9f5317220112d4c9093066d81535c
> kerfuffle/adddialog.ui a1c595b89202b1f2b44dc4f9c2faf68f5f655eb1
> kerfuffle/addtoarchive.h a5bdebad03262f993b97c2dfec75796f15c0b8e1
> kerfuffle/addtoarchive.cpp 6a63839948cd435f04f5dda84b93ebbb52fd4f52
> kerfuffle/archive_kerfuffle.h 886da3eb437cb75442b747223784315abbac1c92
> kerfuffle/archive_kerfuffle.cpp c22d61e0dd72779d7fb64658cc58db7884979455
> kerfuffle/archiveinterface.h 968237d8c09e81ffc39a2e63b0b5f320383df9b7
> kerfuffle/archiveinterface.cpp 686dc060b7e5d84fdaa000aa5c1305ede5a82e73
> kerfuffle/cliinterface.h e93d443d18885c861212edd2d8275852a1ece568
> kerfuffle/cliinterface.cpp 2718c11dd2f9472b43f5a17d61d6d578616fdfbb
> kerfuffle/createdialog.h PRE-CREATION
> kerfuffle/createdialog.cpp PRE-CREATION
> kerfuffle/createdialog.ui PRE-CREATION
> kerfuffle/kerfufflePlugin.desktop 7c194af133e2789a9f2997367c93e68b2c2d6f91
> part/archivemodel.h 13e062d683e53d47bb2a0309a9739190e03581ce
> part/archivemodel.cpp fd70705d67898120053840541124f092e023e4db
> part/part.cpp 9cd27804f633323b7dca9baf4c232754af8ef1b8
> plugins/cli7zplugin/cliplugin.cpp 1c1389f31556669515994a95d59b06ee95726b09
> plugins/cli7zplugin/kerfuffle_cli7z.desktop.cmake \
> b9325f9a765e6d1ba38e666d7eac6e9e34bf0bcb plugins/clirarplugin/cliplugin.cpp \
> 489abd6c1b918e5b87e358e08748703992dfe64b \
> plugins/clirarplugin/kerfuffle_clirar.desktop.cmake \
> 545dca99af5608d10ffe05d5557a5baf92d4b0d1 plugins/clizipplugin/cliplugin.cpp \
> c927581c30a5dd5072cff92e8d0f68e43cd6c588 \
> plugins/clizipplugin/kerfuffle_clizip.desktop.cmake \
> d7451c7b6f045832b1b79f8628eca7491782cc99
> Diff: https://git.reviewboard.kde.org/r/120204/diff/
>
>
> Testing
> -------
>
> Create `.zip`, `.7z` and `.rar` archives using the Ark `AddDialog` dialog (right \
> click on an entry in Dolphin -> Compress -> Compress to...). Those archives are \
> created as expected and their entries are marked as *Password protected*. If the \
> user clicks on those entries, the standard password dialog is prompted to the user. \
>
> File Attachments
> ----------------
>
> passwd-dialog-0.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/8a30505d-47ef-4cf2-ab03-f98fe1891a81__passwd-dialog-0.png
> passwd-dialog-1.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/18288fb9-c822-4e2a-a719-036d452fc39b__passwd-dialog-1.png
> passwd-dialog-2.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/146b3e01-29f6-4cdf-98fd-cc948484d6c0__passwd-dialog-2.png
> passwd-dialog-3.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/7852abea-de46-4e1a-bb4c-82efd73b4823__passwd-dialog-3.png
> show-password.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/2305d88d-7b3d-4f8c-9909-f71eb8cb85f6__show-password.png
> passwd-dialog-4.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/09/721a1c06-9cb7-4e6d-a42a-bded5120e4c1__passwd-dialog-4.png
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
--===============0745779497735319400==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120204/">https://git.reviewboard.kde.org/r/120204/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">\o/ \
Thanks a lot!</p></pre> <br />
<p>- Raphael Kubo da Costa</p>
<br />
<p>On July 22nd, 2015, 2:13 p.m. EEST, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated July 22, 2015, 2:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=253694">253694</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch allows the users to create \
password-protected archives using Ark. The supported plugins are <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">zip</code>, <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7z</code> and \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">rar</code>. The input fields for the \
passwords are displayed only when the relevent mime filters are selected in the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">AddDialog</code> window.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Create <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">.zip</code>, \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">.7z</code> and <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">.rar</code> archives using the Ark <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">AddDialog</code> dialog (right click on an entry in Dolphin -> Compress \
-> Compress to...). Those archives are created as expected and their entries are \
marked as <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Password protected</em>. If the user clicks on those \
entries, the standard password dialog is prompted to the user.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/mainwindow.cpp <span style="color: \
grey">(6511d548e0657f670c3823f63b13c4ca4fa98036)</span></li>
<li>kerfuffle/CMakeLists.txt <span style="color: \
grey">(8d118033571b447f6ce09140417f25abcf9d2f79)</span></li>
<li>kerfuffle/adddialog.h <span style="color: \
grey">(217da1e44d19d869f052aaeab640000a4ea4051c)</span></li>
<li>kerfuffle/adddialog.cpp <span style="color: \
grey">(45aed46404a9f5317220112d4c9093066d81535c)</span></li>
<li>kerfuffle/adddialog.ui <span style="color: \
grey">(a1c595b89202b1f2b44dc4f9c2faf68f5f655eb1)</span></li>
<li>kerfuffle/addtoarchive.h <span style="color: \
grey">(a5bdebad03262f993b97c2dfec75796f15c0b8e1)</span></li>
<li>kerfuffle/addtoarchive.cpp <span style="color: \
grey">(6a63839948cd435f04f5dda84b93ebbb52fd4f52)</span></li>
<li>kerfuffle/archive_kerfuffle.h <span style="color: \
grey">(886da3eb437cb75442b747223784315abbac1c92)</span></li>
<li>kerfuffle/archive_kerfuffle.cpp <span style="color: \
grey">(c22d61e0dd72779d7fb64658cc58db7884979455)</span></li>
<li>kerfuffle/archiveinterface.h <span style="color: \
grey">(968237d8c09e81ffc39a2e63b0b5f320383df9b7)</span></li>
<li>kerfuffle/archiveinterface.cpp <span style="color: \
grey">(686dc060b7e5d84fdaa000aa5c1305ede5a82e73)</span></li>
<li>kerfuffle/cliinterface.h <span style="color: \
grey">(e93d443d18885c861212edd2d8275852a1ece568)</span></li>
<li>kerfuffle/cliinterface.cpp <span style="color: \
grey">(2718c11dd2f9472b43f5a17d61d6d578616fdfbb)</span></li>
<li>kerfuffle/createdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/createdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/createdialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/kerfufflePlugin.desktop <span style="color: \
grey">(7c194af133e2789a9f2997367c93e68b2c2d6f91)</span></li>
<li>part/archivemodel.h <span style="color: \
grey">(13e062d683e53d47bb2a0309a9739190e03581ce)</span></li>
<li>part/archivemodel.cpp <span style="color: \
grey">(fd70705d67898120053840541124f092e023e4db)</span></li>
<li>part/part.cpp <span style="color: \
grey">(9cd27804f633323b7dca9baf4c232754af8ef1b8)</span></li>
<li>plugins/cli7zplugin/cliplugin.cpp <span style="color: \
grey">(1c1389f31556669515994a95d59b06ee95726b09)</span></li>
<li>plugins/cli7zplugin/kerfuffle_cli7z.desktop.cmake <span style="color: \
grey">(b9325f9a765e6d1ba38e666d7eac6e9e34bf0bcb)</span></li>
<li>plugins/clirarplugin/cliplugin.cpp <span style="color: \
grey">(489abd6c1b918e5b87e358e08748703992dfe64b)</span></li>
<li>plugins/clirarplugin/kerfuffle_clirar.desktop.cmake <span style="color: \
grey">(545dca99af5608d10ffe05d5557a5baf92d4b0d1)</span></li>
<li>plugins/clizipplugin/cliplugin.cpp <span style="color: \
grey">(c927581c30a5dd5072cff92e8d0f68e43cd6c588)</span></li>
<li>plugins/clizipplugin/kerfuffle_clizip.desktop.cmake <span style="color: \
grey">(d7451c7b6f045832b1b79f8628eca7491782cc99)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120204/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/8a30505d-47ef-4cf2-ab03-f98fe1891a81__passwd-dialog-0.png">passwd-dialog-0.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/18288fb9-c822-4e2a-a719-036d452fc39b__passwd-dialog-1.png">passwd-dialog-1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/146b3e01-29f6-4cdf-98fd-cc948484d6c0__passwd-dialog-2.png">passwd-dialog-2.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/7852abea-de46-4e1a-bb4c-82efd73b4823__passwd-dialog-3.png">passwd-dialog-3.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/2305d88d-7b3d-4f8c-9909-f71eb8cb85f6__show-password.png">show-password.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/09/721a1c06-9cb7-4e6d-a42a-bded5120e4c1__passwd-dialog-4.png">passwd-dialog-4.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0745779497735319400==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic