[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-utils-devel
Subject: Re: Review Request: enhance performance at updating KWallet Editor Tree
From: "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date: 2012-07-21 18:41:04
Message-ID: 20120721184104.17943.18869 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105633/#review16188
-----------------------------------------------------------
allyourbase.cpp
<http://git.reviewboard.kde.org/r/105633/#comment12770>
This is not your fault as it was that way before, but shouldn't this be translatable? I guess RTL \
languages may want to change the order.
- Rolf Eike Beer
On July 21, 2012, 1:20 p.m., Martin Koller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105633/
> -----------------------------------------------------------
>
> (Updated July 21, 2012, 1:20 p.m.)
>
>
> Review request for KDE Utils, Michael Leupold and Raphael Kubo da Costa.
>
>
> Description
> -------
>
> I have > 340 entries in "Form Data" in the wallet. When opening the wallet editor, it takes about 9 \
> Seconds until the tree is displayed! I investigated the problem and found out that this is due to 2 \
> reasons: 1.) The list of entries is checked against existing entries in the tree, which is done by \
> linear search in the given entries list and in the tree which results in a quadratic complexity.
> 2.) unneeded duplicate dbus calls
>
> I solved the first by using QSet for fast lookup and I reduced the second problem by avoiding a \
> duplicate, unneeded query over dbus
>
> This addresses bugs 279161 and 284671.
> http://bugs.kde.org/show_bug.cgi?id=279161
> http://bugs.kde.org/show_bug.cgi?id=284671
>
>
> Diffs
> -----
>
> allyourbase.h d3452cd
> allyourbase.cpp f57eb68
> kwalleteditor.cpp 777ce8d
>
> Diff: http://git.reviewboard.kde.org/r/105633/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Koller
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105633/">http://git.reviewboard.kde.org/r/105633/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105633/diff/2/?file=74418#file74418line71" style="color: black; \
font-weight: bold; text-decoration: underline;">allyourbase.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QPixmap \
KWalletFolderItem::getFolderIcon(KIconLoader::Group group){</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">71</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">setText</span><span class="p">(</span><span class="mi">0</span><span class="p">,</span> <span \
class="n">QString</span><span class="o">::</span><span class="n">fromLatin1</span><span \
class="p">(</span><span class="s">"%1 (%2)"</span><span class="p">).</span><span \
class="n">arg</span><span class="p">(</span><span class="n">_name</span><span class="p">).</span><span \
class="n">arg</span><span class="p">(</span><span class="n">count</span><span \
class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">This is not your fault as it was that way before, but \
shouldn't this be translatable? I guess RTL languages may want to change the order.</pre> </div>
<br />
<p>- Rolf Eike</p>
<br />
<p>On July 21st, 2012, 1:20 p.m., Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Utils, Michael Leupold and Raphael Kubo da Costa.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated July 21, 2012, 1:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have > 340 entries in "Form \
Data" in the wallet. When opening the wallet editor, it takes about 9 Seconds until the tree is \
displayed! I investigated the problem and found out that this is due to 2 reasons:
1.) The list of entries is checked against existing entries in the tree, which is done by linear search \
in the given entries list and in the tree which results in a quadratic complexity.
2.) unneeded duplicate dbus calls
I solved the first by using QSet for fast lookup and I reduced the second problem by avoiding a \
duplicate, unneeded query over dbus</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279161">279161</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=284671">284671</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>allyourbase.h <span style="color: grey">(d3452cd)</span></li>
<li>allyourbase.cpp <span style="color: grey">(f57eb68)</span></li>
<li>kwalleteditor.cpp <span style="color: grey">(777ce8d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105633/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-utils-devel mailing list
Kde-utils-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-utils-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic