From kde-utils-devel Sat Jul 21 18:41:04 2012 From: "Rolf Eike Beer" Date: Sat, 21 Jul 2012 18:41:04 +0000 To: kde-utils-devel Subject: Re: Review Request: enhance performance at updating KWallet Editor Tree Message-Id: <20120721184104.17943.18869 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-utils-devel&m=134289632925717 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6335315399469976428==" --===============6335315399469976428== Content-Type: multipart/alternative; boundary="===============1934342672185699344==" --===============1934342672185699344== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105633/#review16188 ----------------------------------------------------------- allyourbase.cpp This is not your fault as it was that way before, but shouldn't this be= translatable? I guess RTL languages may want to change the order. - Rolf Eike Beer On July 21, 2012, 1:20 p.m., Martin Koller wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105633/ > ----------------------------------------------------------- > = > (Updated July 21, 2012, 1:20 p.m.) > = > = > Review request for KDE Utils, Michael Leupold and Raphael Kubo da Costa. > = > = > Description > ------- > = > I have > 340 entries in "Form Data" in the wallet. When opening the walle= t editor, it takes about 9 Seconds until the tree is displayed! > I investigated the problem and found out that this is due to 2 reasons: > 1.) The list of entries is checked against existing entries in the tree, = which is done by linear search in the given entries list and in the tree > which results in a quadratic complexity. > 2.) unneeded duplicate dbus calls > = > I solved the first by using QSet for fast lookup and I reduced the second= problem by avoiding a duplicate, unneeded query over dbus > = > = > This addresses bugs 279161 and 284671. > http://bugs.kde.org/show_bug.cgi?id=3D279161 > http://bugs.kde.org/show_bug.cgi?id=3D284671 > = > = > Diffs > ----- > = > allyourbase.h d3452cd = > allyourbase.cpp f57eb68 = > kwalleteditor.cpp 777ce8d = > = > Diff: http://git.reviewboard.kde.org/r/105633/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Martin Koller > = > --===============1934342672185699344== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105633/

= =

allyourbase.cpp (Diff revision 2)
QPixmap KWalletFolderItem::getFolderIcon(KIconLoader::Group group){=
		71	s= etText(0, QString::fromLatin1("%1 (%2)").arg(_name).arg(= count));

This is not your fault as it was that way before, but shouldn't =
this be translatable? I guess RTL languages may want to change the order.

- Rolf Eike

On July 21st, 2012, 1:20 p.m., Martin Koller wrote:

Review request for KDE Utils, Michael Leupold and Raphael Kubo da Cost= a.

By Martin Koller.

Updated July 21, 2012, 1:20 p.m.

Descripti= on

I have > 340 entries in "Form Data" in the wall=
et. When opening the wallet editor, it takes about 9 Seconds until the tree=
 is displayed!
I investigated the problem and found out that this is due to 2 reasons:
1.) The list of entries is checked against existing entries in the tree, wh=
ich is done by linear search in the given entries list and in the tree
    which results in a quadratic complexity.
2.) unneeded duplicate dbus calls

I solved the first by using QSet for fast lookup and I reduced the second p=
roblem by avoiding a duplicate, unneeded query over dbus

Bugs: 279161, = 284671

Diffs=

allyourbase.h (d3452cd)
allyourbase.cpp (f57eb68)
kwalleteditor.cpp (777ce8d)

--===============1934342672185699344==-- --===============6335315399469976428== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-utils-devel mailing list Kde-utils-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-utils-devel --===============6335315399469976428==--