'[KDE Usability] Review Request 108544: Use KUrl::pathOrUrl() instead of prettyUrl()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    [KDE Usability] Review Request 108544: Use KUrl::pathOrUrl() instead of prettyUrl()
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2013-01-22 12:14:36
Message-ID: 20130122121436.8004.51320 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108544/
-----------------------------------------------------------

Review request for KDE Usability and Richard Moore.

Description
-------

No-brainer, gets rid of the file:/// when overwriting a file.

Diffs
-----

  ksnapshotobject.cpp edaf387 

Diff: http://git.reviewboard.kde.org/r/108544/diff/

Testing
-------

Yup, overwriting local file just shows /home/user/some/path.png

Thanks,

Kai Uwe Broulik

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108544/">http://git.reviewboard.kde.org/r/108544/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Usability and Richard Moore.</div>
<div>By Kai Uwe Broulik.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No-brainer, gets rid of the file:/// when overwriting a file.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yup, overwriting local file just shows /home/user/some/path.png</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksnapshotobject.cpp <span style="color: grey">(edaf387)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108544/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability

[prev in list] [next in list] [prev in thread] [next in thread] 