[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-usability
Subject:    Ugly dialogs/layouts in KMail
From:       Hasso Tepper <hasso () kde ! org>
Date:       2005-02-11 17:01:59
Message-ID: 200502111901.59355.hasso () kde ! org
[Download RAW message or body]

Although I'm very pleased with KMail for years, there are some things which 
always annoyed me - some really ugly layouts. Recently things came even 
worse and I thought that I'll look at it. But I must confess that fixing 
these are beyond my knowledge. I'll try to point out at least some worst 
things which really hurt my eye. Some of these might be quite easy to fix 
to the person who knows the code.

Search dialog.

http://hasso.linux.ee/pics/kmail-search.png

This is the worst dialog in KMail. It really needs reorganization, but I'm 
not sure how. But with fixing some small details it might look better. Look 
at filter dropdowns (the ones with text "contain") - much higher than 
previous and next widget. And the statusbar is real alien in this dialog 
IMHO.

Filters dialog.

http://hasso.linux.ee/pics/kmail-filters.png

Same as in search dialog - widgets have different height in both "filter 
criteria" and "filter action" sections. In the "advanced options" section 
there is pointless space before "Additionally add ..." checkbox. At least 
this one I understand why it happens and attached patch should fix that. 
The icon chooser button is still pointlessly wide though. I guess that 
spacers are needed there and maybe more refining layout than 4x4 (it's pain 
to do it manually without designer :). The "Rename..." button in "Available 
filters" section looks like alien.

Mail composer.

It looked OK until new recipients editor was commited (I don't like new one 
personally, dropdown completion have been always all I need, but that's my 
personal tragedy probably).

http://hasso.linux.ee/pics/kmail-composer1.png

Linedits of recipient editor are not aligned correctly and clear button is 
pointlessly wide. This wide button might be issue with style I'm using 
though (Light v3), with some other styles it looks somewhat better, but not 
ideal. Things are going even worse if something is added into layout. I 
added "Sent-mail folder" from "View" menu. The rest of dialog relayouts 
properly, but not recipient editor :(.

http://hasso.linux.ee/pics/kmail-composer2.png

At least small mockup (http://hasso.linux.ee/pics/kmail-composer.ui) in 
designer behaves well, so it should be possible to have nice composer ;).

I can only guess that many of these small issues are there because of 
dynamic dialog building. Horizontal layouts are inserted into dialogs with 
grid layouts as requested. Widgets can't be added to the dialogs as just 
widgets to the grid without additional horizontal layout? But even this 
doesn't explain why have widgets different heights in these horizontal 
layouts.


regards,

-- 
Hasso Tepper
KDE Estonian Team

["kmail-kmfilterdlg.patch" (text/x-diff)]

Index: kmail/kmfilterdlg.cpp
===================================================================
RCS file: /home/kde/kdepim/kmail/kmfilterdlg.cpp,v
retrieving revision 1.120
diff -u -3 -p -r1.120 kmfilterdlg.cpp
--- kmail/kmfilterdlg.cpp	23 Jan 2005 20:40:25 -0000	1.120
+++ kmail/kmfilterdlg.cpp	11 Feb 2005 16:34:12 -0000
@@ -170,7 +170,7 @@ KMFilterDlg::KMFilterDlg(QWidget* parent
       mKeyButton = new KKeyButton( adv_w, "FilterShortcutSelector" );
       gl->addMultiCellWidget( mKeyButton, 2, 2, 3, 3 );
       mConfigureToolbar = new QCheckBox( i18n("Additionally add this filter to the toolbar"), adv_w );
-      gl->addMultiCellWidget( mConfigureToolbar, 3, 3, 1, 3 );
+      gl->addMultiCellWidget( mConfigureToolbar, 3, 3, 0, 3);
       mConfigureToolbar->setEnabled( false );
 
       QHBox *hbox = new QHBox( adv_w );
@@ -185,7 +185,7 @@ KMFilterDlg::KMFilterDlg(QWidget* parent
       mFilterActionIconButton->setIcon( "gear" );
       mFilterActionIconButton->setEnabled( false );
 
-      gl->addMultiCellWidget( hbox, 4, 4, 1, 3 );
+      gl->addMultiCellWidget( hbox, 4, 4, 0, 1 );
     }
     vbl->addWidget( mAdvOptsGroup, 0, Qt::AlignTop );
   }


_______________________________________________
kde-usability mailing list
kde-usability@kde.org
https://mail.kde.org/mailman/listinfo/kde-usability


[prev in list] [next in list] [prev in thread] [next in thread]