'Re: Review Request 129311: [Quick Chat] Trim text that is copied into clipboard'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request 129311: [Quick Chat] Trim text that is copied into clipboard
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2017-02-04 19:03:19
Message-ID: 20170204190319.23300.51017 () mimi ! kde ! org
[Download RAW message or body]

--===============1934724408923575961==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129311/#review102383
-----------------------------------------------------------



Any reason this has not been committed?

- Albert Astals Cid


On Nov. 2, 2016, 10 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129311/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 10 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> Especially when there's spaces at the end you can't really tell them which makes \
> copying passwords annoying. 
> 
> Diffs
> -----
> 
> chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml 5ce61e2 
> 
> Diff: https://git.reviewboard.kde.org/r/129311/diff/
> 
> 
> Testing
> -------
> 
> Sent some text with spaces around, they were trimmed. Spaces within text are left \
> alone. 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 


--===============1934724408923575961==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129311/">https://git.reviewboard.kde.org/r/129311/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Any \
reason this has not been committed?</p></pre>  <br />









<p>- Albert Astals Cid</p>


<br />
<p>On November 2nd, 2016, 10 a.m. UTC, Kai Uwe Broulik wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Kai Uwe Broulik.</div>


<p style="color: grey;"><i>Updated Nov. 2, 2016, 10 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-desktop-applets
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Especially when there's spaces at the end you can't \
really tell them which makes copying passwords annoying.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Sent some text with spaces around, they were trimmed. \
Spaces within text are left alone.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml <span style="color: \
grey">(5ce61e2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129311/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============1934724408923575961==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic