[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 128561: port salut plugin to kf5
From: Björn_Bidar <theodorstormgrade () gmail ! com>
Date: 2017-01-21 0:25:58
Message-ID: 20170121002558.31352.59322 () mimi ! kde ! org
[Download RAW message or body]
--===============4459185812441323313==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128561/
-----------------------------------------------------------
(Updated Jan. 21, 2017, 12:25 a.m.)
Status
------
This change has been marked as submitted.
Review request for Telepathy.
Changes
-------
Submitted with commit 5e36a773bc4540eab0d389b2c74a5d000e5128fa by Albert Astals Cid \
on behalf of Björn Bidar to branch master.
Repository: ktp-accounts-kcm
Description
-------
port salut plugin to kf5
Diffs
-----
data/kaccounts/ktp-salut-im.service.in PRE-CREATION
data/kaccounts/ktp-salut.provider.in PRE-CREATION
plugins/CMakeLists.txt db9bfc458cf1bb9e06d0402d6a03b6c320fbcc3e
plugins/salut/CMakeLists.txt 32a428e8237ee15053255a7f51bf7059abe4c33e
plugins/salut/salut-account-ui-plugin.cpp 79c969a86c9fc27b873fcc04eefb9842ec260918
plugins/salut/salut-advanced-options-widget.ui \
9b05f768be1d855221b4941e99b6fbcd0cc4dcae plugins/salut/salut-main-options-widget.ui \
75d74e3497dc03f65675de1bbbacdc041447536f
Diff: https://git.reviewboard.kde.org/r/128561/diff/
Testing
-------
I ported the plugin to mimic the changes made to the other plugins, however I get the \
message that the handler for this protocoll isn't installed althrough it is. Need \
some help on this.
Thanks,
Björn Bidar
--===============4459185812441323313==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128561/">https://git.reviewboard.kde.org/r/128561/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Björn Bidar.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2017, 12:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 5e36a773bc4540eab0d389b2c74a5d000e5128fa by Albert \
Astals Cid on behalf of Björn Bidar to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-accounts-kcm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">port salut plugin to kf5</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I ported the plugin to mimic the changes made to the \
other plugins, however I get the message that the handler for this protocoll isn't \
installed althrough it is. Need some help on this.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/kaccounts/ktp-salut-im.service.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>data/kaccounts/ktp-salut.provider.in <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/CMakeLists.txt <span style="color: \
grey">(db9bfc458cf1bb9e06d0402d6a03b6c320fbcc3e)</span></li>
<li>plugins/salut/CMakeLists.txt <span style="color: \
grey">(32a428e8237ee15053255a7f51bf7059abe4c33e)</span></li>
<li>plugins/salut/salut-account-ui-plugin.cpp <span style="color: \
grey">(79c969a86c9fc27b873fcc04eefb9842ec260918)</span></li>
<li>plugins/salut/salut-advanced-options-widget.ui <span style="color: \
grey">(9b05f768be1d855221b4941e99b6fbcd0cc4dcae)</span></li>
<li>plugins/salut/salut-main-options-widget.ui <span style="color: \
grey">(75d74e3497dc03f65675de1bbbacdc041447536f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128561/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4459185812441323313==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic