[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 126834: ktp-common-internals propagating presence model
From: Martin Klapetek <martin.klapetek () gmail ! com>
Date: 2017-01-11 18:21:33
Message-ID: 20170111182133.32006.93301 () mimi ! kde ! org
[Download RAW message or body]
--===============1056650815240893390==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 9, 2017, 2:34 p.m., Martin Klapetek wrote:
> > As you've started pushing unreviewed changes (your ship it was for a different \
> > version of the patch), you should either step up as the new maintainer of the \
> > project and assume full responsibility for your code or find someone to review \
> > and approve your code. But please don't push unreviewed code into master \
> > branches, this is in the KDE Telepathy policies as well as general KDE \
> > guidelines.
> > https://community.kde.org/KTp/Developers#Workflow
>
> James Smith wrote:
> The only public-facing change since David's "Ship it!" was a DBus-specific method \
> name change presenceModelChanged() -> propagationChange(). Also included were the \
> Presence changes which were also "Ship it!" in review #123482 and were, except for \
> the use of KTp::Presence over Tp::Presence, applicable to this fix.
That doesn't matter, unreviewed patch is unreviewed patch (and the diff is certainly \
bigger). If you want to continue pushing your changes, please step up as the new \
maintainer of the project.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126834/#review101911
-----------------------------------------------------------
On Jan. 9, 2017, 2 p.m., James Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126834/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 2 p.m.)
>
>
> Review request for Telepathy and David Edmundson.
>
>
> Repository: ktp-common-internals
>
>
> Description
> -------
>
> New features:
> -Simplified API, sends and collects changes over DBus.
>
>
> Diffs
> -----
>
> KTp/Models/presence-model.h 8f206b880f48640626322269a14956f105482f69
> KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519
>
> Diff: https://git.reviewboard.kde.org/r/126834/diff/
>
>
> Testing
> -------
>
> Compile, run.
>
>
> Thanks,
>
> James Smith
>
>
--===============1056650815240893390==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126834/">https://git.reviewboard.kde.org/r/126834/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 9th, 2017, 2:34 p.m. CET, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As you've started pushing unreviewed changes (your \
ship it was for a different version of the patch), you should either step up as the \
new maintainer of the project and assume full responsibility for your code or find \
someone to review and approve your code. But please don't push unreviewed code into \
master branches, this is in the KDE Telepathy policies as well as general KDE \
guidelines.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: \
inherit;">https://community.kde.org/KTp/Developers#Workflow</p></pre> </blockquote>
<p>On January 11th, 2017, 12:26 a.m. CET, <b>James Smith</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
only public-facing change since David's "Ship it!" was a DBus-specific method name \
change presenceModelChanged() -> propagationChange(). Also included were the \
Presence changes which were also "Ship it!" in review #123482 and were, except for \
the use of KTp::Presence over Tp::Presence, applicable to this fix.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That \
doesn't matter, unreviewed patch is unreviewed patch (and the diff is certainly \
bigger). If you want to continue pushing your changes, please step up as the new \
maintainer of the project.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On January 9th, 2017, 2 p.m. CET, James Smith wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2017, 2 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-common-internals
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">New features:
-Simplified API, sends and collects changes over DBus.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compile, run.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/Models/presence-model.h <span style="color: \
grey">(8f206b880f48640626322269a14956f105482f69)</span></li>
<li>KTp/Models/presence-model.cpp <span style="color: \
grey">(ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126834/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1056650815240893390==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic