[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request 108598: Create the new types enum - Important please review !
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2013-01-26 13:34:03
Message-ID: 20130126133403.21614.6300 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108598/#review26204
-----------------------------------------------------------
KTp/types.h
<http://git.reviewboard.kde.org/r/108598/#comment19920>
Neither of these are me, and the top line simply isn't true.
Needs fixing.
- David Edmundson
On Jan. 26, 2013, 1:33 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108598/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2013, 1:33 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Create the new types enum.
>
> This is really important. Please please review.
> Give a "ship it!" if you're happy with the enum. I will only push into the \
> model_refactor_3 branch.
> Obviously this won't compile, I want to make sure people are happy with this \
> _before_ we start changing all the other code. We can add roles later, but I don't \
> want to be editing or deleting them.
> I'm also not sure whether I should namespace the enum so we don't have roles at the \
> top level of the KTp namespace? (i.e namespace KTp { namespace ContactModelRoles { \
> enum ModelRoles{ ..... ) ? Thoughts?
> (what's not shown in the diff is that I've also deleted/merged the ktp-metatypes.h \
> file)
>
> Diffs
> -----
>
> KTp/CMakeLists.txt 10c17bf1f915db9fed59f2d11421cb73a38cebae
> KTp/Models/accounts-tree-proxy-model.cpp ead34f6a1b019535caeb77e05eb7332e71d82f5c
> KTp/Models/contacts-filter-model.cpp 145dcef38593edc10d1efb3f6dc5e188723ecc8e
> KTp/Models/contacts-list-model.h 876a485a65eacad7fa8663dd7c221f52c1ae7ff1
> KTp/Models/contacts-model.h 2a9cf44736e6e3aea5f92eb09e6840314ba94247
> KTp/ktp-metatypes.h 9488ee5cbe059d831466b1a1115e2ff359457bac
> KTp/types.h PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/108598/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108598/">http://git.reviewboard.kde.org/r/108598/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108598/diff/1/?file=109299#file109299line5" \
style="color: black; font-weight: bold; text-decoration: underline;">KTp/types.h</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">5</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * Copyright (C) 2010 Collabora Ltd. \
<info@collabora.co.uk></span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">6</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * Copyright (C) 2011 Martin Klapetek <martin dot klapetek at gmail dot \
com></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Neither of \
these are me, and the top line simply isn't true.
Needs fixing.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On January 26th, 2013, 1:33 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Jan. 26, 2013, 1:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Create the new types enum.
This is really important. Please please review.
Give a "ship it!" if you're happy with the enum. I will only push into \
the model_refactor_3 branch.
Obviously this won't compile, I want to make sure people are happy with this \
_before_ we start changing all the other code. We can add roles later, but I \
don't want to be editing or deleting them.
I'm also not sure whether I should namespace the enum so we don't have roles \
at the top level of the KTp namespace? (i.e namespace KTp { namespace \
ContactModelRoles { enum ModelRoles{ ..... ) ? Thoughts?
(what's not shown in the diff is that I've also deleted/merged the \
ktp-metatypes.h file)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/CMakeLists.txt <span style="color: \
grey">(10c17bf1f915db9fed59f2d11421cb73a38cebae)</span></li>
<li>KTp/Models/accounts-tree-proxy-model.cpp <span style="color: \
grey">(ead34f6a1b019535caeb77e05eb7332e71d82f5c)</span></li>
<li>KTp/Models/contacts-filter-model.cpp <span style="color: \
grey">(145dcef38593edc10d1efb3f6dc5e188723ecc8e)</span></li>
<li>KTp/Models/contacts-list-model.h <span style="color: \
grey">(876a485a65eacad7fa8663dd7c221f52c1ae7ff1)</span></li>
<li>KTp/Models/contacts-model.h <span style="color: \
grey">(2a9cf44736e6e3aea5f92eb09e6840314ba94247)</span></li>
<li>KTp/ktp-metatypes.h <span style="color: \
grey">(9488ee5cbe059d831466b1a1115e2ff359457bac)</span></li>
<li>KTp/types.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108598/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic