'Review Request 108598: Create the new types enum - Important please review !'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Review Request 108598: Create the new types enum - Important please review !
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2013-01-26 13:33:18
Message-ID: 20130126133318.21614.77370 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108598/
-----------------------------------------------------------

Review request for Telepathy.

Description
-------

Create the new types enum.

This is really important. Please please review. 
Give a "ship it!" if you're happy with the enum. I will only push into the \
model_refactor_3 branch.

Obviously this won't compile, I want to make sure people are happy with this _before_ \
we start changing all the other code. We can add roles later, but I don't want to be \
editing or deleting them. 

I'm also not sure whether I should namespace the enum so we don't have roles at the \
top level of the KTp namespace?  (i.e namespace KTp { namespace ContactModelRoles { \
enum ModelRoles{ .....  ) ? Thoughts?

(what's not shown in the diff is that I've also deleted/merged the ktp-metatypes.h \
file)

Diffs
-----

  KTp/CMakeLists.txt 10c17bf1f915db9fed59f2d11421cb73a38cebae 
  KTp/Models/accounts-tree-proxy-model.cpp ead34f6a1b019535caeb77e05eb7332e71d82f5c 
  KTp/Models/contacts-filter-model.cpp 145dcef38593edc10d1efb3f6dc5e188723ecc8e 
  KTp/Models/contacts-list-model.h 876a485a65eacad7fa8663dd7c221f52c1ae7ff1 
  KTp/Models/contacts-model.h 2a9cf44736e6e3aea5f92eb09e6840314ba94247 
  KTp/ktp-metatypes.h 9488ee5cbe059d831466b1a1115e2ff359457bac 
  KTp/types.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/108598/diff/

Testing
-------

Thanks,

David Edmundson

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108598/">http://git.reviewboard.kde.org/r/108598/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Create the new types enum.

This is really important. Please please review. 
Give a &quot;ship it!&quot; if you&#39;re happy with the enum. I will only push into \
the model_refactor_3 branch.

Obviously this won&#39;t compile, I want to make sure people are happy with this \
_before_ we start changing all the other code. We can add roles later, but I \
don&#39;t want to be editing or deleting them. 

I&#39;m also not sure whether I should namespace the enum so we don&#39;t have roles \
at the top level of the KTp namespace?  (i.e namespace KTp { namespace \
ContactModelRoles { enum ModelRoles{ .....  ) ? Thoughts?

(what&#39;s not shown in the diff is that I&#39;ve also deleted/merged the \
ktp-metatypes.h file)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>KTp/CMakeLists.txt <span style="color: \
grey">(10c17bf1f915db9fed59f2d11421cb73a38cebae)</span></li>

 <li>KTp/Models/accounts-tree-proxy-model.cpp <span style="color: \
grey">(ead34f6a1b019535caeb77e05eb7332e71d82f5c)</span></li>

 <li>KTp/Models/contacts-filter-model.cpp <span style="color: \
grey">(145dcef38593edc10d1efb3f6dc5e188723ecc8e)</span></li>

 <li>KTp/Models/contacts-list-model.h <span style="color: \
grey">(876a485a65eacad7fa8663dd7c221f52c1ae7ff1)</span></li>

 <li>KTp/Models/contacts-model.h <span style="color: \
grey">(2a9cf44736e6e3aea5f92eb09e6840314ba94247)</span></li>

 <li>KTp/ktp-metatypes.h <span style="color: \
grey">(9488ee5cbe059d831466b1a1115e2ff359457bac)</span></li>

 <li>KTp/types.h <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108598/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 