'Re: Review Request: Baby steps for Chat Plasmoid...'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request: Baby steps for Chat Plasmoid...
From:       "David Edmundson" <kde () davidedmundson ! co ! uk>
Date:       2012-01-11 21:34:56
Message-ID: 20120111213456.12469.64245 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103629/#review9755
-----------------------------------------------------------

lib/CMakeLists.txt
<http://git.reviewboard.kde.org/r/103629/#comment8051>

    Try not to commit commented out code.

    (also if this is what I think it's for, I'm not sure it's a great name)

lib/conversations-model.cpp
<http://git.reviewboard.kde.org/r/103629/#comment8055>

    Try to put constructors as the first method.

lib/qml-plugins.cpp
<http://git.reviewboard.kde.org/r/103629/#comment8052>

    You really don't need to register all these types.

    Only register the stuff that you should be able to create in QML.

    Especially when actually using it would result in immediately throwing a kError. \
(which applies to at least one of these classes)  
    I think you only need ConversationsModel. Though you will then need to fix a few \
things just like we did with conversationtarget.  Even for your single person chat, \
you're only going to have one entry point, you'd never construct a messagesModel \
(etc) from inside QML.  
    Plus you'll be able to tidy up some stuff because of it.

lib/telepathy-text-observer.h
<http://git.reviewboard.kde.org/r/103629/#comment8053>

    You can't call a class that isn't acting as TelepathyTextObserverPrivate "d". \
It's thoroughly confusing.  Rename it.

plasmoid/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/103629/#comment8056>

    try to avoid committing large chunks of commented out code. 

plasmoid/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/103629/#comment8054>

    No.

- David Edmundson

On Jan. 10, 2012, 10:01 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103629/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2012, 10:01 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Right, I decided that I should have reviewed and/or merge what work I've done so \
> far rather than letting it pile up in its corner into a giant worthless clump.  
> To the people that haven't heard (or wasn't at woshibon), this is a chat plasmoid \
> that more or less behaves like facebook and google talk, except it sits in your \
> taskbar :) 
> And in terms of feedback, at this stage I think design issues should take priority \
> over sane code because the main reason I'm doing this is because I don't want to \
> have to do any massive restructuring later on. 
> And if things don't make sense, ask me (I didn't comment/document anything well and \
> I'm certainly too sleepy now ;) 
> PS: All the code is in my scratch repo
> http://quickgit.kde.org/?p=clones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplugin.git&a=shortlog&h=refs/heads/qml_plugins2
>  
> 
> Diffs
> -----
> 
> CMakeLists.txt d1cc185 
> lib/CMakeLists.txt 5d39a62 
> lib/adium-theme-content-info.h e293732 
> lib/adium-theme-header-info.h 952dc48 
> lib/adium-theme-message-info.h 10c00a2 
> lib/adium-theme-status-info.h 926586a 
> lib/adium-theme-view.h c2fae74 
> lib/adium-theme-view.cpp c834c94 
> lib/chat-search-bar.h 315fd2b 
> lib/chat-search-bar.cpp 15aa5da 
> lib/chat-text-edit.cpp b0476f5 
> lib/chat-widget.h 30afa31 
> lib/chat-widget.cpp 9313c03 
> lib/chat-window-style-manager.h c876ba8 
> lib/chat-window-style-manager.cpp 8604c97 
> lib/chat-window-style.cpp 7b770cf 
> lib/conversation-que-manager.h PRE-CREATION 
> lib/conversation-que-manager.cpp PRE-CREATION 
> lib/conversation-target.h PRE-CREATION 
> lib/conversation-target.cpp PRE-CREATION 
> lib/conversation.h PRE-CREATION 
> lib/conversation.cpp PRE-CREATION 
> lib/conversations-model.h PRE-CREATION 
> lib/conversations-model.cpp PRE-CREATION 
> lib/logmanager.h 4e11086 
> lib/logmanager.cpp 61484af 
> lib/messages-model.h PRE-CREATION 
> lib/messages-model.cpp PRE-CREATION 
> lib/qml-plugins.h PRE-CREATION 
> lib/qml-plugins.cpp PRE-CREATION 
> lib/qmldir PRE-CREATION 
> lib/telepathy-text-observer.h PRE-CREATION 
> lib/telepathy-text-observer.cpp PRE-CREATION 
> plasmoid/CMakeLists.txt PRE-CREATION 
> plasmoid/contents/ui/ChatWidget.qml PRE-CREATION 
> plasmoid/contents/ui/ConversationDelegate.qml PRE-CREATION 
> plasmoid/contents/ui/TextDelegate.qml PRE-CREATION 
> plasmoid/contents/ui/main.qml PRE-CREATION 
> plasmoid/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103629/diff/diff
> 
> 
> Testing
> -------
> 
> Um.. yeah... about that...    :/
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103629/">http://git.reviewboard.kde.org/r/103629/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103629/diff/5/?file=46307#file46307line27" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/CMakeLists.txt</a>  <span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">#         \
static-conversation.cpp</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Try not to \
commit commented out code.

(also if this is what I think it&#39;s for, I&#39;m not sure it&#39;s a great \
name)</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103629/diff/5/?file=46329#file46329line50" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/conversations-model.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">int ConversationsModel::rowCount(const QModelIndex&amp; parent) const</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">ConversationsModel</span><span class="o">::</span><span \
class="n">ConversationsModel</span><span class="p">(</span><span \
class="n">QObject</span> <span class="o">*</span><span class="n">parent</span><span \
class="p">)</span> <span class="o">:</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Try to put \
constructors as the first method.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103629/diff/5/?file=46335#file46335line29" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/qml-plugins.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">QmlPlugins</span><span \
class="o">::</span><span class="n">registerTypes</span> <span class="p">(</span> \
<span class="k">const</span> <span class="kt">char</span> <span \
class="o">*</span><span class="n">uri</span> <span class="p">)</span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You really \
don&#39;t need to register all these types.

Only register the stuff that you should be able to create in QML.

Especially when actually using it would result in immediately throwing a kError. \
(which applies to at least one of these classes)

I think you only need ConversationsModel. Though you will then need to fix a few \
things just like we did with conversationtarget. Even for your single person chat, \
you&#39;re only going to have one entry point, you&#39;d never construct a \
messagesModel (etc) from inside QML.

Plus you&#39;ll be able to tidy up some stuff because of it.</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103629/diff/5/?file=46337#file46337line41" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/telepathy-text-observer.h</a>  <span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">private:</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">41</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="n">Tp</span><span class="o">::</span><span \
class="n">SharedPtr</span><span class="o">&lt;</span><span \
class="n">ConversationClientObserver</span><span class="o">&gt;</span> <span \
class="n">d</span> <span class="cm">/*= \
Tp::SharedPtr&lt;ConversationClientObserver&gt;()*/</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You \
can&#39;t call a class that isn&#39;t acting as TelepathyTextObserverPrivate \
&quot;d&quot;. It&#39;s thoroughly confusing. Rename it.</pre>
</div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103629/diff/5/?file=46343#file46343line74" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoid/contents/ui/main.qml</a>  <span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">74</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">//            \
function popupApplet() {</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">try to \
avoid committing large chunks of commented out code. </pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/103629/diff/5/?file=46343#file46343line95" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmoid/contents/ui/main.qml</a>  <span style="font-weight: normal;">

     (Diff revision 5)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">95</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        \
console.log(&quot;deeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeerrrrrrrrrrrrrrrrp!&quot;);</pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No.</pre> \
</div> <br />

<p>- David</p>

<br />
<p>On January 10th, 2012, 10:01 a.m., Lasath Fernando wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy and David Edmundson.</div>
<div>By Lasath Fernando.</div>

<p style="color: grey;"><i>Updated Jan. 10, 2012, 10:01 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Right, I decided that I should have reviewed and/or merge what work \
I&#39;ve done so far rather than letting it pile up in its corner into a giant \
worthless clump. 

To the people that haven&#39;t heard (or wasn&#39;t at woshibon), this is a chat \
plasmoid that more or less behaves like facebook and google talk, except it sits in \
your taskbar :)

And in terms of feedback, at this stage I think design issues should take priority \
over sane code because the main reason I&#39;m doing this is because I don&#39;t want \
to have to do any massive restructuring later on.

And if things don&#39;t make sense, ask me (I didn&#39;t comment/document anything \
well and I&#39;m certainly too sleepy now ;)

PS: All the code is in my scratch repo
http://quickgit.kde.org/?p=clones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplugin.git&amp;a=shortlog&amp;h=refs/heads/qml_plugins2</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Um.. yeah... about that...    :/</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(d1cc185)</span></li>

 <li>lib/CMakeLists.txt <span style="color: grey">(5d39a62)</span></li>

 <li>lib/adium-theme-content-info.h <span style="color: grey">(e293732)</span></li>

 <li>lib/adium-theme-header-info.h <span style="color: grey">(952dc48)</span></li>

 <li>lib/adium-theme-message-info.h <span style="color: grey">(10c00a2)</span></li>

 <li>lib/adium-theme-status-info.h <span style="color: grey">(926586a)</span></li>

 <li>lib/adium-theme-view.h <span style="color: grey">(c2fae74)</span></li>

 <li>lib/adium-theme-view.cpp <span style="color: grey">(c834c94)</span></li>

 <li>lib/chat-search-bar.h <span style="color: grey">(315fd2b)</span></li>

 <li>lib/chat-search-bar.cpp <span style="color: grey">(15aa5da)</span></li>

 <li>lib/chat-text-edit.cpp <span style="color: grey">(b0476f5)</span></li>

 <li>lib/chat-widget.h <span style="color: grey">(30afa31)</span></li>

 <li>lib/chat-widget.cpp <span style="color: grey">(9313c03)</span></li>

 <li>lib/chat-window-style-manager.h <span style="color: grey">(c876ba8)</span></li>

 <li>lib/chat-window-style-manager.cpp <span style="color: \
grey">(8604c97)</span></li>

 <li>lib/chat-window-style.cpp <span style="color: grey">(7b770cf)</span></li>

 <li>lib/conversation-que-manager.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>lib/conversation-que-manager.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>lib/conversation-target.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/conversation-target.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/conversation.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/conversation.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/conversations-model.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/conversations-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/logmanager.h <span style="color: grey">(4e11086)</span></li>

 <li>lib/logmanager.cpp <span style="color: grey">(61484af)</span></li>

 <li>lib/messages-model.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/messages-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/qml-plugins.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/qml-plugins.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/qmldir <span style="color: grey">(PRE-CREATION)</span></li>

 <li>lib/telepathy-text-observer.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>lib/telepathy-text-observer.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasmoid/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>plasmoid/contents/ui/ChatWidget.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasmoid/contents/ui/ConversationDelegate.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasmoid/contents/ui/TextDelegate.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasmoid/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasmoid/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103629/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 