This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103629/

= =

lib/CMakeLists.txt (Diff revision 5)

		27	# static-conversation.cpp

Try not to commit commented out code.

(also if this is what I think it's for, I'm not sure it's a gre=
at name)

= =

lib/conversations-model.cpp (Diff revision 5)
	int ConversationsModel::rowCount(const QModelIndex& parent) con= st
		50	ConversationsModel::ConversationsModel(QObject *parent) :

Try to put constructors as the first method.

= =

lib/qml-plugins.cpp (Diff revision 5)

		29	void QmlPlugins::registerTy= pes ( const char *uri )

You really don't need to register all these types.

Only register the stuff that you should be able to create in QML.

Especially when actually using it would result in immediately throwing a kE=
rror. (which applies to at least one of these classes)

I think you only need ConversationsModel. Though you will then need to fix =
a few things just like we did with conversationtarget.
Even for your single person chat, you're only going to have one entry p=
oint, you'd never construct a messagesModel (etc) from inside QML.

Plus you'll be able to tidy up some stuff because of it.

= =

lib/telepathy-text-observer.h (Diff revision 5)
	private:
		41	T= p::SharedPtr<ConversationClientObserver<= span class=3D"o">> d = /=3D Tp::SharedPtr<ConversationClientObserver>()/;

You can't call a class that isn't acting as TelepathyTextObs=
erverPrivate "d". It's thoroughly confusing.
Rename it.

= =

plasmoid/contents/ui/main.qml (Diff revision 5)

		74	// function popupApplet() { <= /td>

try to avoid committing large chunks of commented out code.

= =

plasmoid/contents/ui/main.qml (Diff revision 5)

		95	console.log("deeeeeeeeeeeeeeeeeee= eeeeeeeeeeeeeeeeeeeeeeeeeeeeerrrrrrrrrrrrrrrrp!");

No.

- David

On January 10th, 2012, 10:01 a.m., Lasath Fernando wrote:

Review request for Telepathy and David Edmundson.

By Lasath Fernando.

Updated Jan. 10, 2012, 10:01 a.m.

Descripti= on

Right, I decided that I should have reviewed and/or merge wh=
at work I've done so far rather than letting it pile up in its corner i=
nto a giant worthless clump. =


To the people that haven't heard (or wasn't at woshibon), this is a=
 chat plasmoid that more or less behaves like facebook and google talk, exc=
ept it sits in your taskbar :)

And in terms of feedback, at this stage I think design issues should take p=
riority over sane code because the main reason I'm doing this is becaus=
e I don't want to have to do any massive restructuring later on.

And if things don't make sense, ask me (I didn't comment/document a=
nything well and I'm certainly too sleepy now ;)

PS: All the code is in my scratch repo
http://quickgit.kde.org/?p=3Dclones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplu=
gin.git&a=3Dshortlog&h=3Drefs/heads/qml_plugins2

Testing <= /h1>

Um.. yeah... about that...    :/

Diffs=

CMakeLists.txt (d1cc185)
lib/CMakeLists.txt (5d39a62)
lib/adium-theme-content-info.h (e293732)
lib/adium-theme-header-info.h (952dc48)
lib/adium-theme-message-info.h (10c00a2)
lib/adium-theme-status-info.h (926586a)
lib/adium-theme-view.h (c2fae74)
lib/adium-theme-view.cpp (c834c94)<= /li>
lib/chat-search-bar.h (315fd2b)
lib/chat-search-bar.cpp (15aa5da)
lib/chat-text-edit.cpp (b0476f5)
lib/chat-widget.h (30afa31)
lib/chat-widget.cpp (9313c03)
lib/chat-window-style-manager.h (c876ba8)<= /span>
lib/chat-window-style-manager.cpp (8604c97= )
lib/chat-window-style.cpp (7b770cf)=
lib/conversation-que-manager.h (PRE-CREATI= ON)
lib/conversation-que-manager.cpp (PRE-CREA= TION)
lib/conversation-target.h (PRE-CREATION)
lib/conversation-target.cpp (PRE-CREATION)=
lib/conversation.h (PRE-CREATION)
lib/conversation.cpp (PRE-CREATION)=
lib/conversations-model.h (PRE-CREATION)
lib/conversations-model.cpp (PRE-CREATION)=
lib/logmanager.h (4e11086)
lib/logmanager.cpp (61484af)
lib/messages-model.h (PRE-CREATION)=
lib/messages-model.cpp (PRE-CREATION)
lib/qml-plugins.h (PRE-CREATION)
lib/qml-plugins.cpp (PRE-CREATION)<= /li>
lib/qmldir (PRE-CREATION)
lib/telepathy-text-observer.h (PRE-CREATIO= N)
lib/telepathy-text-observer.cpp (PRE-CREAT= ION)
plasmoid/CMakeLists.txt (PRE-CREATION)
plasmoid/contents/ui/ChatWidget.qml (PRE-C= REATION)
plasmoid/contents/ui/ConversationDelegate.qml (PRE-CREATION)
plasmoid/contents/ui/TextDelegate.qml (PRE= -CREATION)
plasmoid/contents/ui/main.qml (PRE-CREATIO= N)
plasmoid/metadata.desktop (PRE-CREATION)

View Diff