[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request: Baby steps for Chat Plasmoid...
From: "Lasath Fernando" <kde () lasath ! org>
Date: 2012-01-09 11:52:37
Message-ID: 20120109115237.3971.97825 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103629/
-----------------------------------------------------------
(Updated Jan. 9, 2012, 11:52 a.m.)
Review request for Telepathy and David Edmundson.
Changes
-------
Removed chat-window-style.cpp from diff, as it only contained useless formatting \
changes.
Description
-------
Right, I decided that I should have reviewed and/or merge what work I've done so far \
rather than letting it pile up in its corner into a giant worthless clump.
To the people that haven't heard (or wasn't at woshibon), this is a chat plasmoid \
that more or less behaves like facebook and google talk, except it sits in your \
taskbar :)
And in terms of feedback, at this stage I think design issues should take priority \
over sane code because the main reason I'm doing this is because I don't want to have \
to do any massive restructuring later on.
And if things don't make sense, ask me (I didn't comment/document anything well and \
I'm certainly too sleepy now ;)
PS: All the code is in my scratch repo
http://quickgit.kde.org/?p=clones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplugin.git&a=shortlog&h=refs/heads/qml_plugins2
Diffs (updated)
-----
CMakeLists.txt d1cc185
lib/CMakeLists.txt 5d39a62
lib/conversation-que-manager.h PRE-CREATION
lib/conversation-que-manager.cpp PRE-CREATION
lib/conversation-target.h PRE-CREATION
lib/conversation-target.cpp PRE-CREATION
lib/conversation.h PRE-CREATION
lib/conversation.cpp PRE-CREATION
lib/conversations-model.h PRE-CREATION
lib/conversations-model.cpp PRE-CREATION
lib/messages-model.h PRE-CREATION
lib/messages-model.cpp PRE-CREATION
lib/qml-plugins.h PRE-CREATION
lib/qml-plugins.cpp PRE-CREATION
lib/qmldir PRE-CREATION
lib/telepathy-text-observer.h PRE-CREATION
lib/telepathy-text-observer.cpp PRE-CREATION
plasmoid/CMakeLists.txt PRE-CREATION
plasmoid/contents/ui/ChatWidget.qml PRE-CREATION
plasmoid/contents/ui/ConversationDelegate.qml PRE-CREATION
plasmoid/contents/ui/TextDelegate.qml PRE-CREATION
plasmoid/contents/ui/main.qml PRE-CREATION
plasmoid/metadata.desktop PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/103629/diff/diff
Testing
-------
Um.. yeah... about that... :/
Thanks,
Lasath Fernando
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103629/">http://git.reviewboard.kde.org/r/103629/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By Lasath Fernando.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2012, 11:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removed chat-window-style.cpp from diff, as it only contained useless \
formatting changes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Right, I decided that I should have reviewed and/or merge what work \
I've done so far rather than letting it pile up in its corner into a giant \
worthless clump.
To the people that haven't heard (or wasn't at woshibon), this is a chat \
plasmoid that more or less behaves like facebook and google talk, except it sits in \
your taskbar :)
And in terms of feedback, at this stage I think design issues should take priority \
over sane code because the main reason I'm doing this is because I don't want \
to have to do any massive restructuring later on.
And if things don't make sense, ask me (I didn't comment/document anything \
well and I'm certainly too sleepy now ;)
PS: All the code is in my scratch repo
http://quickgit.kde.org/?p=clones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplugin.git&a=shortlog&h=refs/heads/qml_plugins2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Um.. yeah... about that... :/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d1cc185)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(5d39a62)</span></li>
<li>lib/conversation-que-manager.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/conversation-que-manager.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/conversation-target.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/conversation-target.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/conversation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/conversation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/conversations-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/conversations-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/messages-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/messages-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/qml-plugins.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/qml-plugins.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/telepathy-text-observer.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lib/telepathy-text-observer.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmoid/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>plasmoid/contents/ui/ChatWidget.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmoid/contents/ui/ConversationDelegate.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmoid/contents/ui/TextDelegate.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmoid/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasmoid/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103629/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic