--===============0082348824237954592==
Content-Type: multipart/alternative;
boundary="===============6522753844417758884=="
--===============6522753844417758884==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103629/
-----------------------------------------------------------
(Updated Jan. 9, 2012, 11:52 a.m.)
Review request for Telepathy and David Edmundson.
Changes
-------
Removed chat-window-style.cpp from diff, as it only contained useless forma=
tting changes.
Description
-------
Right, I decided that I should have reviewed and/or merge what work I've do=
ne so far rather than letting it pile up in its corner into a giant worthle=
ss clump. =
To the people that haven't heard (or wasn't at woshibon), this is a chat pl=
asmoid that more or less behaves like facebook and google talk, except it s=
its in your taskbar :)
And in terms of feedback, at this stage I think design issues should take p=
riority over sane code because the main reason I'm doing this is because I =
don't want to have to do any massive restructuring later on.
And if things don't make sense, ask me (I didn't comment/document anything =
well and I'm certainly too sleepy now ;)
PS: All the code is in my scratch repo
http://quickgit.kde.org/?p=3Dclones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplu=
gin.git&a=3Dshortlog&h=3Drefs/heads/qml_plugins2
Diffs (updated)
-----
CMakeLists.txt d1cc185 =
lib/CMakeLists.txt 5d39a62 =
lib/conversation-que-manager.h PRE-CREATION =
lib/conversation-que-manager.cpp PRE-CREATION =
lib/conversation-target.h PRE-CREATION =
lib/conversation-target.cpp PRE-CREATION =
lib/conversation.h PRE-CREATION =
lib/conversation.cpp PRE-CREATION =
lib/conversations-model.h PRE-CREATION =
lib/conversations-model.cpp PRE-CREATION =
lib/messages-model.h PRE-CREATION =
lib/messages-model.cpp PRE-CREATION =
lib/qml-plugins.h PRE-CREATION =
lib/qml-plugins.cpp PRE-CREATION =
lib/qmldir PRE-CREATION =
lib/telepathy-text-observer.h PRE-CREATION =
lib/telepathy-text-observer.cpp PRE-CREATION =
plasmoid/CMakeLists.txt PRE-CREATION =
plasmoid/contents/ui/ChatWidget.qml PRE-CREATION =
plasmoid/contents/ui/ConversationDelegate.qml PRE-CREATION =
plasmoid/contents/ui/TextDelegate.qml PRE-CREATION =
plasmoid/contents/ui/main.qml PRE-CREATION =
plasmoid/metadata.desktop PRE-CREATION =
Diff: http://git.reviewboard.kde.org/r/103629/diff/diff
Testing
-------
Um.. yeah... about that... :/
Thanks,
Lasath Fernando
--===============6522753844417758884==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Review request for Telepathy and David Edmundson.
By Lasath Fernando.
Updated Jan. 9, 2012, 11:52 a.m.
Changes=
h1>
Removed chat-window-style.cpp from diff, as it only containe=
d useless formatting changes.
|
Descripti=
on
Right, I decided that I should have reviewed and/or merge wh=
at work I've done so far rather than letting it pile up in its corner i=
nto a giant worthless clump. =
To the people that haven't heard (or wasn't at woshibon), this is a=
chat plasmoid that more or less behaves like facebook and google talk, exc=
ept it sits in your taskbar :)
And in terms of feedback, at this stage I think design issues should take p=
riority over sane code because the main reason I'm doing this is becaus=
e I don't want to have to do any massive restructuring later on.
And if things don't make sense, ask me (I didn't comment/document a=
nything well and I'm certainly too sleepy now ;)
PS: All the code is in my scratch repo
http://quickgit.kde.org/?p=3Dclones%2Ftelepathy-text-ui%2Ffernando%2Fqmlplu=
gin.git&a=3Dshortlog&h=3Drefs/heads/qml_plugins2
|
Testing <=
/h1>
Um.. yeah... about that... :/
|
Diffs=
(updated)
- CMakeLists.txt (d1cc185)
- lib/CMakeLists.txt (5d39a62)
- lib/conversation-que-manager.h (PRE-CREATI=
ON)
- lib/conversation-que-manager.cpp (PRE-CREA=
TION)
- lib/conversation-target.h (PRE-CREATION)=
span>
- lib/conversation-target.cpp (PRE-CREATION)=
- lib/conversation.h (PRE-CREATION)=
li>
- lib/conversation.cpp (PRE-CREATION)=
- lib/conversations-model.h (PRE-CREATION)=
span>
- lib/conversations-model.cpp (PRE-CREATION)=
- lib/messages-model.h (PRE-CREATION)=
- lib/messages-model.cpp (PRE-CREATION)
- lib/qml-plugins.h (PRE-CREATION)
- lib/qml-plugins.cpp (PRE-CREATION)<=
/li>
- lib/qmldir (PRE-CREATION)
- lib/telepathy-text-observer.h (PRE-CREATIO=
N)
- lib/telepathy-text-observer.cpp (PRE-CREAT=
ION)
- plasmoid/CMakeLists.txt (PRE-CREATION)
- plasmoid/contents/ui/ChatWidget.qml (PRE-C=
REATION)
- plasmoid/contents/ui/ConversationDelegate.qml (PRE-CREATION)
- plasmoid/contents/ui/TextDelegate.qml (PRE=
-CREATION)
- plasmoid/contents/ui/main.qml (PRE-CREATIO=
N)
- plasmoid/metadata.desktop (PRE-CREATION)=
span>
View Diff
|
--===============6522753844417758884==--
--===============0082348824237954592==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
--===============0082348824237954592==--