[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Gwenview ui file in 15.08
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2015-10-10 13:36:03
Message-ID: 8766215.TDbdzJtCdO () xps
[Download RAW message or body]

El Saturday 10 October 2015, a les 12:11:51, David Edmundson va escriure:
> On Wed, Oct 7, 2015 at 10:13 PM, Luigi Toscano <luigi.toscano@tiscali.it>
> 
> wrote:
> > Hi Ivan,
> > the change you committed few months ago to Gwenview:
> > 
> > https://quickgit.kde.org/?p=gwenview.git&a=commit&h=78e4e57af3a5476dd94979
> > 7c559a3d25d8ce50a1
> > 
> > broke the loading of the menu, as the ui file still has the old name and
> > there
> > is no explicit setting of the .ui file name.
> > 
> > There is a bug for this and two review requests:
> > https://bugs.kde.org/show_bug.cgi?id=351431
> > 
> > The older RR reverts your change:
> > https://git.reviewboard.kde.org/r/125216/
> > 
> > The newer one renames the .ui file on installation and fixes the
> > directory.
> > https://git.reviewboard.kde.org/r/125524/
> > 
> > Could you please comment on the proper way to solve this? (if you can do
> > before tomorrow, October 8, this can go in for 15.08.2).
> 
> I'm not sure we can revert, it changes the file path of one of the config
> files used too.
> 
> Second patch looks OK, and I've given it some testing, and it seems to be
> fine.
> I'll merge it now, given it's fairly major would it be possible to have a
> respin of gwenview for Applications 15.08.2?

Done.

> 
> David

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread]