[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Gwenview ui file in 15.08
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2015-10-10 11:11:51
Message-ID: CAGeFrHA0GC95PuNCfYgHOj4TVyRmSjpNZKOz5TynsAQsO5MaZQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Wed, Oct 7, 2015 at 10:13 PM, Luigi Toscano <luigi.toscano@tiscali.it>
wrote:

> Hi Ivan,
> the change you committed few months ago to Gwenview:
>
> https://quickgit.kde.org/?p=gwenview.git&a=commit&h=78e4e57af3a5476dd949797c559a3d25d8ce50a1
>
> broke the loading of the menu, as the ui file still has the old name and
> there
> is no explicit setting of the .ui file name.
>
> There is a bug for this and two review requests:
> https://bugs.kde.org/show_bug.cgi?id=351431
>
> The older RR reverts your change:
> https://git.reviewboard.kde.org/r/125216/
>
> The newer one renames the .ui file on installation and fixes the directory.
> https://git.reviewboard.kde.org/r/125524/
>
> Could you please comment on the proper way to solve this? (if you can do
> before tomorrow, October 8, this can go in for 15.08.2).
>

I'm not sure we can revert, it changes the file path of one of the config
files used too.

Second patch looks OK, and I've given it some testing, and it seems to be
fine.
I'll merge it now, given it's fairly major would it be possible to have a
respin of gwenview for Applications 15.08.2?

David

[Attachment #5 (text/html)]

<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct \
7, 2015 at 10:13 PM, Luigi Toscano <span dir="ltr">&lt;<a \
href="mailto:luigi.toscano@tiscali.it" \
target="_blank">luigi.toscano@tiscali.it</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Ivan,<br> the change you committed few months ago to \
Gwenview:<br> <a href="https://quickgit.kde.org/?p=gwenview.git&amp;a=commit&amp;h=78e4e57af3a5476dd949797c559a3d25d8ce50a1" \
rel="noreferrer" target="_blank">https://quickgit.kde.org/?p=gwenview.git&amp;a=commit&amp;h=78e4e57af3a5476dd949797c559a3d25d8ce50a1</a><br>
 <br>
broke the loading of the menu, as the ui file still has the old name and there<br>
is no explicit setting of the .ui file name.<br>
<br>
There is a bug for this and two review requests:<br>
<a href="https://bugs.kde.org/show_bug.cgi?id=351431" rel="noreferrer" \
target="_blank">https://bugs.kde.org/show_bug.cgi?id=351431</a><br> <br>
The older RR reverts your change:<br>
<a href="https://git.reviewboard.kde.org/r/125216/" rel="noreferrer" \
target="_blank">https://git.reviewboard.kde.org/r/125216/</a><br> <br>
The newer one renames the .ui file on installation and fixes the directory.<br>
<a href="https://git.reviewboard.kde.org/r/125524/" rel="noreferrer" \
target="_blank">https://git.reviewboard.kde.org/r/125524/</a><br> <br>
Could you please comment on the proper way to solve this? (if you can do<br>
before tomorrow, October 8, this can go in for 15.08.2).<br>
</blockquote><div><br></div><div>I&#39;m not sure we can revert, it changes the file \
path of one of the config files used too.<br><br></div><div>Second patch looks OK, \
and I&#39;ve given it some testing, and it seems to be fine.<br></div><div>I&#39;ll \
merge it now, given it&#39;s fairly major would it be possible to have a respin of \
gwenview for Applications \
15.08.2?<br></div><div><br></div><div>David<br></div></div></div></div>


[Attachment #6 (text/plain)]

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


[prev in list] [next in list] [prev in thread] [next in thread]