'Re: Review Request 111949: Backup ResourceListGenerator: Do not only count files with tags'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request 111949: Backup ResourceListGenerator: Do not only count files with tags
From:       "Simeon Bird" <bladud () gmail ! com>
Date:       2013-08-09 19:29:22
Message-ID: 20130809192922.16607.82993 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111949/#review37447
-----------------------------------------------------------

Ship it!

again, not super-familiar with this code, but for what my opinion is worth, it looks good.

- Simeon Bird

On Aug. 8, 2013, 7:04 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111949/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2013, 7:04 p.m.)
> 
> 
> Review request for Nepomuk and Release Team.
> 
> 
> Description
> -------
> 
>     Only files with tags used to be backed up. If a file had only a rating
>     or a comment then its information would not be backed up.
> 
> 
> Diffs
> -----
> 
>   autotests/test/backuptests.cpp 7284dd6 
>   services/storage/backup/resourcelistgenerator.cpp 059bfa7 
> 
> Diff: http://git.reviewboard.kde.org/r/111949/diff/
> 
> 
> Testing
> -------
> 
> Tested by manually backing up a number of times.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111949/">http://git.reviewboard.kde.org/r/111949/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">again, not \
super-familiar with this code, but for what my opinion is worth, it looks good.</pre> \
<br />

<p>- Simeon</p>

<br />
<p>On August 8th, 2013, 7:04 p.m. UTC, Vishesh Handa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk and Release Team.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated Aug. 8, 2013, 7:04 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    Only files with tags used to be backed up. If a file had only a \
rating  or a comment then its information would not be backed up.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested by manually backing up a number of times.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/test/backuptests.cpp <span style="color: grey">(7284dd6)</span></li>

 <li>services/storage/backup/resourcelistgenerator.cpp <span style="color: \
grey">(059bfa7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111949/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 