[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request 111949: Backup ResourceListGenerator: Do not only count files with tags
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2013-08-08 21:18:18
Message-ID: 20130808211818.30505.73842 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 8, 2013, 9:06 p.m., Albert Astals Cid wrote:
> > I can confirm that the new test fails without the patch and works with it. I \
> > can't assess the correctness of the code itself since my nepomuk-foo ? 0
> > It'd be cool if someone else from nepomuk-land can try to review. If not I'll \
> > guess we'll have to trust Vishesh and commit it :-)
I can vouch that the patch looks sensible and will do what Vishesh says.
Ship it from me.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111949/#review37385
-----------------------------------------------------------
On Aug. 8, 2013, 7:04 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111949/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 7:04 p.m.)
>
>
> Review request for Nepomuk and Release Team.
>
>
> Description
> -------
>
> Only files with tags used to be backed up. If a file had only a rating
> or a comment then its information would not be backed up.
>
>
> Diffs
> -----
>
> autotests/test/backuptests.cpp 7284dd6
> services/storage/backup/resourcelistgenerator.cpp 059bfa7
>
> Diff: http://git.reviewboard.kde.org/r/111949/diff/
>
>
> Testing
> -------
>
> Tested by manually backing up a number of times.
>
>
> Thanks,
>
> Vishesh Handa
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111949/">http://git.reviewboard.kde.org/r/111949/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 8th, 2013, 9:06 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I can confirm that the new test fails without the patch and works with \
it. I can't assess the correctness of the code itself since my nepomuk-foo ? 0
It'd be cool if someone else from nepomuk-land can try to review. If not I'll \
guess we'll have to trust Vishesh and commit it :-)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can vouch that the \
patch looks sensible and will do what Vishesh says. Ship it from me.</pre>
<br />
<p>- David</p>
<br />
<p>On August 8th, 2013, 7:04 p.m. UTC, Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Nepomuk and Release Team.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2013, 7:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"> Only files with tags used to be backed up. If a file had only a \
rating or a comment then its information would not be backed up.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested by manually backing up a number of times.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/test/backuptests.cpp <span style="color: grey">(7284dd6)</span></li>
<li>services/storage/backup/resourcelistgenerator.cpp <span style="color: \
grey">(059bfa7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111949/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic