'Review Request 111947: Backup Statement Generator: statements without a datatype can be valid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Review Request 111947: Backup Statement Generator: statements without a datatype can be valid
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2013-08-08 17:52:58
Message-ID: 20130808175258.1247.48878 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111947/
-----------------------------------------------------------

Review request for Nepomuk and Release Team.

Description
-------

    Backup Statement Generator: statements without a datatype can be valid

    In Nepomuk the nao:description is stored as an rdfs literal, which means
    it doesn't have a datatype, but is supposed to have a language tag.
    Since we don't store the language tag, it is just stored as a string.
    This used to be considered invalid by the statement generator and
    therefore the nao:description (dolphin comments) was never backed up
    even though it was requested.

    BUG: 323260

It's important to get this into 4.11 otherwise everyone will loose their comments on \
installing 4.11 as the migration is done through backup.

This addresses bug 323260.
    http://bugs.kde.org/show_bug.cgi?id=323260

Diffs
-----

  services/storage/backup/statementgenerator.cpp c3b5985 

Diff: http://git.reviewboard.kde.org/r/111947/diff/

Testing
-------

Tested by manually backing up a number of times.

Thanks,

Vishesh Handa

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111947/">http://git.reviewboard.kde.org/r/111947/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk and Release Team.</div>
<div>By Vishesh Handa.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    Backup Statement Generator: statements without a datatype can be \
valid  
    In Nepomuk the nao:description is stored as an rdfs literal, which means
    it doesn&#39;t have a datatype, but is supposed to have a language tag.
    Since we don&#39;t store the language tag, it is just stored as a string.
    This used to be considered invalid by the statement generator and
    therefore the nao:description (dolphin comments) was never backed up
    even though it was requested.

    BUG: 323260

It&#39;s important to get this into 4.11 otherwise everyone will loose their comments \
on installing 4.11 as the migration is done through backup.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested by manually backing up a number of times.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=323260">323260</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>services/storage/backup/statementgenerator.cpp <span style="color: \
grey">(c3b5985)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111947/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 