--===============8356042996379535511== Content-Type: multipart/alternative; boundary="===============4641704980848454784==" --===============4641704980848454784== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111947/ ----------------------------------------------------------- Review request for Nepomuk and Release Team. Description ------- Backup Statement Generator: statements without a datatype can be valid In Nepomuk the nao:description is stored as an rdfs literal, which means it doesn't have a datatype, but is supposed to have a language tag. Since we don't store the language tag, it is just stored as a string. This used to be considered invalid by the statement generator and therefore the nao:description (dolphin comments) was never backed up even though it was requested. BUG: 323260 It's important to get this into 4.11 otherwise everyone will loose their comments on installing 4.11 as the migration is done through backup. This addresses bug 323260. http://bugs.kde.org/show_bug.cgi?id=323260 Diffs ----- services/storage/backup/statementgenerator.cpp c3b5985 Diff: http://git.reviewboard.kde.org/r/111947/diff/ Testing ------- Tested by manually backing up a number of times. Thanks, Vishesh Handa --===============4641704980848454784== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111947/

Review request for Nepomuk and Release Team.

By Vishesh Handa.

Description

    Backup Statement Generator: statements without a datatype can be valid
    
    In Nepomuk the nao:description is stored as an rdfs literal, which means
    it doesn't have a datatype, but is supposed to have a language tag.
    Since we don't store the language tag, it is just stored as a string.
    This used to be considered invalid by the statement generator and
    therefore the nao:description (dolphin comments) was never backed up
    even though it was requested.
    
    BUG: 323260

It's important to get this into 4.11 otherwise everyone will loose their comments on installing 4.11 as the migration is done through backup.

Testing

Tested by manually backing up a number of times.

Bugs: 323260

Diffs

services/storage/backup/statementgenerator.cpp (c3b5985)

View Diff

--===============4641704980848454784==-- --===============8356042996379535511== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team --===============8356042996379535511==--