[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request: ktouch: require at least KDE SC 4.10 RC 1 libaries
From: "Commit Hook" <null () kde ! org>
Date: 2012-12-29 16:05:12
Message-ID: 20121229160512.30686.44234 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107999/#review24189
-----------------------------------------------------------
This review has been submitted with commit 3f4b7c12336f1bb472a48636129a3310=
e782c768 by Sebastian Gottfried to branch KDE/4.10.
- Commit Hook
On Dec. 29, 2012, 11:42 a.m., Sebastian Gottfried wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107999/
> -----------------------------------------------------------
> =
> (Updated Dec. 29, 2012, 11:42 a.m.)
> =
> =
> Review request for Release Team.
> =
> =
> Description
> -------
> =
> Up to now I was requiring the last released version of the KDE SC to buil=
d KTouch, but behavioral changes to the Plasma QML components introduced in=
this development cycle make this impossible. Now it's impossible to get pi=
xel perfect results on both 4.9 and 4.10. Obviously I'm focusing on 4.10 as=
this is the version KTouch is released with. Additionally I introduced acc=
identally a real dependency on 4.10 when fixing the issues I had with the n=
ew Plasma QML components version by using some newly introduced properies. =
I could theoretically revert these changes, but it would result in less tha=
n pixel-perfect results.
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt e370126 =
> =
> Diff: http://git.reviewboard.kde.org/r/107999/diff/
> =
> =
> Testing
> -------
> =
> N/A
> =
> =
> Thanks,
> =
> Sebastian Gottfried
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107999/">http://git.reviewboard.kde.org/r/107999/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 3f4b7c12336f1bb472a48636129a3310e782c768 by Sebastian Gottfried \
to branch KDE/4.10.</pre> <br />
<p>- Commit</p>
<br />
<p>On December 29th, 2012, 11:42 a.m., Sebastian Gottfried wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Release Team.</div>
<div>By Sebastian Gottfried.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2012, 11:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Up to now I was requiring the last released version of the KDE SC to \
build KTouch, but behavioral changes to the Plasma QML components introduced in this \
development cycle make this impossible. Now it's impossible to get pixel perfect \
results on both 4.9 and 4.10. Obviously I'm focusing on 4.10 as this is the \
version KTouch is released with. Additionally I introduced accidentally a real \
dependency on 4.10 when fixing the issues I had with the new Plasma QML components \
version by using some newly introduced properies. I could theoretically revert these \
changes, but it would result in less than pixel-perfect results.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">N/A</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e370126)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107999/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic