From kde-release-team Sat Dec 29 16:05:12 2012 From: "Commit Hook" Date: Sat, 29 Dec 2012 16:05:12 +0000 To: kde-release-team Subject: Re: Review Request: ktouch: require at least KDE SC 4.10 RC 1 libaries Message-Id: <20121229160512.30686.44234 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-release-team&m=135679722107979 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7200074059726445988==" --===============7200074059726445988== Content-Type: multipart/alternative; boundary="===============2474565802606280807==" --===============2474565802606280807== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107999/#review24189 ----------------------------------------------------------- This review has been submitted with commit 3f4b7c12336f1bb472a48636129a3310= e782c768 by Sebastian Gottfried to branch KDE/4.10. - Commit Hook On Dec. 29, 2012, 11:42 a.m., Sebastian Gottfried wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107999/ > ----------------------------------------------------------- > = > (Updated Dec. 29, 2012, 11:42 a.m.) > = > = > Review request for Release Team. > = > = > Description > ------- > = > Up to now I was requiring the last released version of the KDE SC to buil= d KTouch, but behavioral changes to the Plasma QML components introduced in= this development cycle make this impossible. Now it's impossible to get pi= xel perfect results on both 4.9 and 4.10. Obviously I'm focusing on 4.10 as= this is the version KTouch is released with. Additionally I introduced acc= identally a real dependency on 4.10 when fixing the issues I had with the n= ew Plasma QML components version by using some newly introduced properies. = I could theoretically revert these changes, but it would result in less tha= n pixel-perfect results. > = > = > Diffs > ----- > = > CMakeLists.txt e370126 = > = > Diff: http://git.reviewboard.kde.org/r/107999/diff/ > = > = > Testing > ------- > = > N/A > = > = > Thanks, > = > Sebastian Gottfried > = > --===============2474565802606280807== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107999/ 

This revie=
w has been submitted with commit 3f4b7c12336f1bb472a48636129a3310e782c768 b=
y Sebastian Gottfried to branch KDE/4.10.

- Commit


On December 29th, 2012, 11:42 a.m., Sebastian Gottfried wrote:

Review request for Release Team.
By Sebastian Gottfried.

Updated Dec. 29, 2012, 11:42 a.m.

Descripti= on 

Up to now I was requiring the last released version of the K=
DE SC to build KTouch, but behavioral changes to the Plasma QML components =
introduced in this development cycle make this impossible. Now it's imp=
ossible to get pixel perfect results on both 4.9 and 4.10. Obviously I'=
m focusing on 4.10 as this is the version KTouch is released with. Addition=
ally I introduced accidentally a real dependency on 4.10 when fixing the is=
sues I had with the new Plasma QML components version by using some newly i=
ntroduced properies. I could theoretically revert these changes, but it wou=
ld result in less than pixel-perfect results.

Testing <= /h1> 
N/A

Diffs=

  • CMakeLists.txt (e370126)

View Diff
--===============2474565802606280807==-- --===============7200074059726445988== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team --===============7200074059726445988==--