'Re: Broken build of KDE Base Apps and unauthorized increase in dependency'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Broken build of KDE Base Apps and unauthorized increase in dependency
From:       Dawit A <adawit () kde ! org>
Date:       2012-09-12 18:04:02
Message-ID: CALa28R6M9drbooXL1jxy4=iEwxhnHWq4PeZzh-H-7cn1fAhQwg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

On Tue, Sep 11, 2012 at 9:05 AM, Dawit A <adawit@kde.org> wrote:

>
>
> On Tue, Sep 11, 2012 at 6:22 AM, Ben Cooksley <bcooksley@kde.org> wrote:
>
>> Hi Dawit,
>>
>> It has come to my attention that since commit
>> 603a93268efb9d09f8c6255907f46928c651fdbd to kde-baseapps master, the
>> build for it has been broken.
>> This is due to it depending on new features, present only in the KDE/4.9
>> branch.
>>
>
> That is only a temporary situation. All the changes in the 4.9 branch are
> periodically merged into
> the 4.10 branch by David, but I guess that does not resolve this issue.
>
>
>
>> This is problematic because:
>> - kde-baseapps depends upon a minimum of 4.7.97 (ie. KDE 4.8) which
>> obviously is no longer the case. It depends upon unreleased code.
>>
>
> Ahh... I was not aware of this was a requirement though I still do not
> understand why we have started insisting on forward compatibility.
> Regardless, I will fix this since it is only a matter of wrapping the code
> with #ifdef.
>
>
>> - This feature will not be in KDE 4.10 at the moment, because the
>> feature was added to KDE/4.9 instead of KDE/4.10 as it should have
>> been.
>>
>
> It is not a new feature. It is a bug fix. It is needed to fix the
> directory filter plugin for Konqueror.
>

First, sorry I confused kdelibs with kde-baseapps in this response. So
forget what I said about changes being merged back into 4.10 branch by
David. Anyhow, I have now attempted to fix this issue as reported here. See

http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b
.

However this fix does not really work. That is compile will fail if KDE
version is changed to 4.9.2 as well because Qt's moc processor does not
seem to correctly handle #if macros. So my question is whether it would be
acceptable for me to revert this change from the git 4.9 branch and simply
leave it as it was in the git master branch ? IOW, kde-baseapps 4.10
release will have a minimum requirement of kdelibs 4.9.2 ?

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Tue, Sep 11, 2012 at 9:05 AM, Dawit A <span \
dir="ltr">&lt;<a href="mailto:adawit@kde.org" \
target="_blank">adawit@kde.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">

<br><br><div class="gmail_quote"><div class="im">On Tue, Sep 11, 2012 at 6:22 AM, Ben \
Cooksley <span dir="ltr">&lt;<a href="mailto:bcooksley@kde.org" \
target="_blank">bcooksley@kde.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">

Hi Dawit,<br>
<br>
It has come to my attention that since commit<br>
603a93268efb9d09f8c6255907f46928c651fdbd to kde-baseapps master, the<br>
build for it has been broken.<br>
This is due to it depending on new features, present only in the KDE/4.9 \
branch.<br></blockquote><div><br></div></div><div>That is only a temporary situation. \
All the changes in the 4.9 branch are periodically merged into</div>

<div>the 4.10 branch by David, but I guess that does not resolve this issue.  \
</div><div class="im"><div><br></div><div>  </div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

This is problematic because:<br>

- kde-baseapps depends upon a minimum of 4.7.97 (ie. KDE 4.8) which<br>
obviously is no longer the case. It depends upon unreleased \
code.<br></blockquote><div><br></div></div><div>Ahh... I was not aware of this was a \
requirement though I still do not understand why we have started insisting on forward \
compatibility. Regardless, I will fix this since it is only a matter of wrapping the \
code with #ifdef.</div>

<div class="im">
<div>  </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
                #ccc solid;padding-left:1ex">
- This feature will not be in KDE 4.10 at the moment, because the<br>
feature was added to KDE/4.9 instead of KDE/4.10 as it should have<br>
been.<br></blockquote><div><br></div></div><div>It is not a new feature. It is a bug \
fix. It is needed to fix the directory filter plugin for Konqueror.</div></div> \
</blockquote></div><br><div>First, sorry I confused kdelibs with kde-baseapps in this \
response. So forget what I said about changes being merged back into 4.10 branch by \
David. Anyhow, I have now attempted to fix this issue as reported here. See   <a \
href="http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b">ht \
tp://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b</a>.</div>

<div><br></div><div>However this fix does not really work. That is compile will fail \
if KDE version is changed to 4.9.2 as well because Qt&#39;s moc processor does not \
seem to correctly handle #if macros. So my question is whether it would be acceptable \
for me to revert this change from the git 4.9 branch and simply leave it as it was in \
the git master branch ? IOW, kde-baseapps 4.10 release will have a minimum \
requirement of kdelibs 4.9.2 ?</div>

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 