--===============4098450936677370541==
Content-Type: multipart/alternative; boundary=e89a8f923a4a7ca5d804c98506f5

--e89a8f923a4a7ca5d804c98506f5
Content-Type: text/plain; charset=UTF-8

On Tue, Sep 11, 2012 at 9:05 AM, Dawit A <adawit@kde.org> wrote:

>
>
> On Tue, Sep 11, 2012 at 6:22 AM, Ben Cooksley <bcooksley@kde.org> wrote:
>
>> Hi Dawit,
>>
>> It has come to my attention that since commit
>> 603a93268efb9d09f8c6255907f46928c651fdbd to kde-baseapps master, the
>> build for it has been broken.
>> This is due to it depending on new features, present only in the KDE/4.9
>> branch.
>>
>
> That is only a temporary situation. All the changes in the 4.9 branch are
> periodically merged into
> the 4.10 branch by David, but I guess that does not resolve this issue.
>
>
>
>> This is problematic because:
>> - kde-baseapps depends upon a minimum of 4.7.97 (ie. KDE 4.8) which
>> obviously is no longer the case. It depends upon unreleased code.
>>
>
> Ahh... I was not aware of this was a requirement though I still do not
> understand why we have started insisting on forward compatibility.
> Regardless, I will fix this since it is only a matter of wrapping the code
> with #ifdef.
>
>
>> - This feature will not be in KDE 4.10 at the moment, because the
>> feature was added to KDE/4.9 instead of KDE/4.10 as it should have
>> been.
>>
>
> It is not a new feature. It is a bug fix. It is needed to fix the
> directory filter plugin for Konqueror.
>

First, sorry I confused kdelibs with kde-baseapps in this response. So
forget what I said about changes being merged back into 4.10 branch by
David. Anyhow, I have now attempted to fix this issue as reported here. See

http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b
.

However this fix does not really work. That is compile will fail if KDE
version is changed to 4.9.2 as well because Qt's moc processor does not
seem to correctly handle #if macros. So my question is whether it would be
acceptable for me to revert this change from the git 4.9 branch and simply
leave it as it was in the git master branch ? IOW, kde-baseapps 4.10
release will have a minimum requirement of kdelibs 4.9.2 ?

--e89a8f923a4a7ca5d804c98506f5
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<br><br><div class=3D"gmail_quote">On Tue, Sep 11, 2012 at 9:05 AM, Dawit A=
 <span dir=3D"ltr">&lt;<a href=3D"mailto:adawit@kde.org" target=3D"_blank">=
adawit@kde.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br><br><div class=3D"gmail_quote"><div class=3D"im">On Tue, Sep 11, 2012 a=
t 6:22 AM, Ben Cooksley <span dir=3D"ltr">&lt;<a href=3D"mailto:bcooksley@k=
de.org" target=3D"_blank">bcooksley@kde.org</a>&gt;</span> wrote:<br><block=
quote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc=
 solid;padding-left:1ex">



Hi Dawit,<br>
<br>
It has come to my attention that since commit<br>
603a93268efb9d09f8c6255907f46928c651fdbd to kde-baseapps master, the<br>
build for it has been broken.<br>
This is due to it depending on new features, present only in the KDE/4.9 br=
anch.<br></blockquote><div><br></div></div><div>That is only a temporary si=
tuation. All the changes in the 4.9 branch are periodically merged into</di=
v>



<div>the 4.10 branch by David, but I guess that does not resolve this issue=
.=C2=A0</div><div class=3D"im"><div><br></div><div>=C2=A0</div><blockquote =
class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid=
;padding-left:1ex">

This is problematic because:<br>

- kde-baseapps depends upon a minimum of 4.7.97 (ie. KDE 4.8) which<br>
obviously is no longer the case. It depends upon unreleased code.<br></bloc=
kquote><div><br></div></div><div>Ahh... I was not aware of this was a requi=
rement though I still do not understand why we have started insisting on fo=
rward compatibility. Regardless, I will fix this since it is only a matter =
of wrapping the code with #ifdef.</div>

<div class=3D"im">
<div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex">
- This feature will not be in KDE 4.10 at the moment, because the<br>
feature was added to KDE/4.9 instead of KDE/4.10 as it should have<br>
been.<br></blockquote><div><br></div></div><div>It is not a new feature. It=
 is a bug fix. It is needed to fix the directory filter plugin for Konquero=
r.</div></div>
</blockquote></div><br><div>First, sorry I confused kdelibs with kde-baseap=
ps in this response. So forget what I said about changes being merged back =
into 4.10 branch by David. Anyhow, I have now attempted to fix this issue a=
s reported here. See =C2=A0<a href=3D"http://commits.kde.org/kde-baseapps/f=
0d5e062bf0452258d337d7dcb2edd2eefa1c37b">http://commits.kde.org/kde-baseapp=
s/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b</a>.</div>

<div><br></div><div>However this fix does not really work. That is compile =
will fail if KDE version is changed to 4.9.2 as well because Qt&#39;s moc p=
rocessor does not seem to correctly handle #if macros. So my question is wh=
ether it would be acceptable for me to revert this change from the git 4.9 =
branch and simply leave it as it was in the git master branch ? IOW, kde-ba=
seapps 4.10 release will have a minimum requirement of kdelibs 4.9.2 ?</div=
>


--e89a8f923a4a7ca5d804c98506f5--

--===============4098450936677370541==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

--===============4098450936677370541==--