'Re: Review Request: only remove old parent nodes' pointer when add new parent'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request: only remove old parent nodes' pointer when add new parent
From:       "Albert Astals Cid" <tsdgeos () terra ! es>
Date:       2012-07-31 21:49:25
Message-ID: 20120731214925.32388.46002 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105601/#review16726
-----------------------------------------------------------

Can you guys please remove the release-team group so it does not show up in our "todo queue"?

- Albert Astals Cid

On July 17, 2012, 4:23 p.m., Wagner de Melo Reck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105601/
> -----------------------------------------------------------
> 
> (Updated July 17, 2012, 4:23 p.m.)
> 
> 
> Review request for Release Team and Andreas Cord-Landwehr.
> 
> 
> Description
> -------
> 
> Do not remove child pointers in rooted tree if addeding the parent. It's part of 303570 bug's fix 
> 
> 
> This addresses bug 303570.
>     http://bugs.kde.org/show_bug.cgi?id=303570
> 
> 
> Diffs
> -----
> 
>   src/Plugins/DataStructure/RootedTree/RootedTreeNode.cpp ddbf6cb 
> 
> Diff: http://git.reviewboard.kde.org/r/105601/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wagner de Melo Reck
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105601/">http://git.reviewboard.kde.org/r/105601/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you guys please \
remove the release-team group so it does not show up in our &quot;todo \
queue&quot;?</pre>  <br />

<p>- Albert</p>

<br />
<p>On July 17th, 2012, 4:23 p.m., Wagner de Melo Reck wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Release Team and Andreas Cord-Landwehr.</div>
<div>By Wagner de Melo Reck.</div>

<p style="color: grey;"><i>Updated July 17, 2012, 4:23 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Do not remove child pointers in rooted tree if addeding the parent. \
It&#39;s part of 303570 bug&#39;s fix </pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=303570">303570</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/Plugins/DataStructure/RootedTree/RootedTreeNode.cpp <span style="color: \
grey">(ddbf6cb)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105601/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 