[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request: only remove old parent nodes' pointer when add new parent
From: "Andreas Cord-Landwehr" <cola () uni-paderborn ! de>
Date: 2012-07-17 18:42:47
Message-ID: 20120717184247.31207.51384 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 17, 2012, 4:50 p.m., Albert Astals Cid wrote:
> > We are not in a freeze at the moment, so the release team opinion is irrelevant.
> >
> > Cheers,
> > Albert
>
> Wagner de Melo Reck wrote:
> Aren't we at RC 2? This patch is also to be applied in the branch 4.9.
>
> greetings,
>
> Wagner
Due to http://techbase.kde.org/Schedules/KDE4/4.9_Release_Schedule, only during the \
tagging freezes or if you are adding a new dependency in dependency freeze you have \
to add release team as reviewer. For this patch at this time it is enough to set the \
kde-edu group as reviewer.
Greetings,
Andreas
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105601/#review16014
-----------------------------------------------------------
On July 17, 2012, 4:23 p.m., Wagner de Melo Reck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105601/
> -----------------------------------------------------------
>
> (Updated July 17, 2012, 4:23 p.m.)
>
>
> Review request for Release Team and Andreas Cord-Landwehr.
>
>
> Description
> -------
>
> Do not remove child pointers in rooted tree if addeding the parent. It's part of \
> 303570 bug's fix
>
> This addresses bug 303570.
> http://bugs.kde.org/show_bug.cgi?id=303570
>
>
> Diffs
> -----
>
> src/Plugins/DataStructure/RootedTree/RootedTreeNode.cpp ddbf6cb
>
> Diff: http://git.reviewboard.kde.org/r/105601/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Wagner de Melo Reck
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105601/">http://git.reviewboard.kde.org/r/105601/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 17th, 2012, 4:50 p.m., <b>Albert Astals \
Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We are not in a freeze at the moment, so the release team opinion is \
irrelevant.
Cheers,
Albert</pre>
</blockquote>
<p>On July 17th, 2012, 6:37 p.m., <b>Wagner de Melo Reck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Aren't we at RC 2? \
This patch is also to be applied in the branch 4.9.
greetings,
Wagner</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Due to \
http://techbase.kde.org/Schedules/KDE4/4.9_Release_Schedule, only during the tagging \
freezes or if you are adding a new dependency in dependency freeze you have to add \
release team as reviewer. For this patch at this time it is enough to set the kde-edu \
group as reviewer.
Greetings,
Andreas</pre>
<br />
<p>- Andreas</p>
<br />
<p>On July 17th, 2012, 4:23 p.m., Wagner de Melo Reck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Release Team and Andreas Cord-Landwehr.</div>
<div>By Wagner de Melo Reck.</div>
<p style="color: grey;"><i>Updated July 17, 2012, 4:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Do not remove child pointers in rooted tree if addeding the parent. \
It's part of 303570 bug's fix </pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=303570">303570</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Plugins/DataStructure/RootedTree/RootedTreeNode.cpp <span style="color: \
grey">(ddbf6cb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105601/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic