[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request: Add git support to kdesdk: create_tarball.rb
From: Kåre Särs <kare.sars () iki ! fi>
Date: 2011-11-30 21:01:15
Message-ID: 20111130210115.14176.4211 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 30, 2011, 6:01 p.m., Thomas Baumgart wrote:
> > trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb, line 443
> > <http://svn.reviewboard.kde.org/r/6842/diff/1/?file=47267#file47267line443>
> >
> > Is there a specific reason why you don't add the doc subdirectory for stuff \
> > fetched from git?
The git modules I have checked, have the non-translated documents in the git repo and \
the directory already added in the CMakeLists.txt. I take it that, that is the \
"standard" :) So the documentation should actually be built.
- Kåre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6842/#review10493
-----------------------------------------------------------
On Nov. 29, 2011, 4:42 p.m., Kåre Särs wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6842/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2011, 4:42 p.m.)
>
>
> Review request for kdelibs and Release Team.
>
>
> Description
> -------
>
> This patch adds git support to create_tarball.rb in kdesdk. The patch adds two \
> options to the ini file. The first one (gitModule) indicates that the module is \
> located in git and the second optional parameter (gitTag) defines which tag to use \
> for creating the release. (there is no group for kdesdk or extragear)
>
> Diffs
> -----
>
> trunk/KDE/kdesdk/scripts/createtarball/config.ini 1266277
> trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb 1266277
>
> Diff: http://svn.reviewboard.kde.org/r/6842/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kåre Särs
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6842/">http://svn.reviewboard.kde.org/r/6842/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 30th, 2011, 6:01 p.m., <b>Thomas \
Baumgart</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6842/diff/1/?file=47267#file47267line443" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">429</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="n">appdata</span><span class="o">[</span><span \
class="s2">"docs"</span><span class="o">]</span> <span class="o">!=</span> \
<span class="s2">"no"</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">442</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p"><span class="hl">(</span></span><span class="n">appdata</span><span \
class="o">[</span><span class="s2">"docs"</span><span class="o">]</span> \
<span class="o">!=</span> <span class="s2">"no"</span><span class="p"><span \
class="hl">)</span></span><span class="hl"> </span><span class="o"><span \
class="hl">&&</span></span><span class="hl"> </span><span class="p"><span \
class="hl">(</span></span><span class="o"><span class="hl">!</span></span><span \
class="n"><span class="hl">appdata</span></span><span class="o"><span \
class="hl">[</span></span><span class="s2"><span \
class="hl">"gitModule"</span></span><span class="o"><span \
class="hl">]</span></span><span class="p"><span class="hl">)</span></span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there a specific \
reason why you don't add the doc subdirectory for stuff fetched from git?</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The git \
modules I have checked, have the non-translated documents in the git repo and the \
directory already added in the CMakeLists.txt. I take it that, that is the \
"standard" :) So the documentation should actually be built.</pre> <br />
<p>- Kåre</p>
<br />
<p>On November 29th, 2011, 4:42 p.m., Kåre Särs wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Release Team.</div>
<div>By Kåre Särs.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2011, 4:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds git support to create_tarball.rb in kdesdk. The patch \
adds two options to the ini file. The first one (gitModule) indicates that the module \
is located in git and the second optional parameter (gitTag) defines which tag to use \
for creating the release. (there is no group for kdesdk or extragear)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdesdk/scripts/createtarball/config.ini <span style="color: \
grey">(1266277)</span></li>
<li>trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb <span style="color: \
grey">(1266277)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6842/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic