From kde-release-team Wed Nov 30 21:01:15 2011 From: =?utf-8?b?S8OlcmUgU8OkcnM=?= Date: Wed, 30 Nov 2011 21:01:15 +0000 To: kde-release-team Subject: Re: Review Request: Add git support to kdesdk: create_tarball.rb Message-Id: <20111130210115.14176.4211 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-release-team&m=132286293810303 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7104204477396596477==" --===============7104204477396596477== Content-Type: multipart/alternative; boundary="===============1304397856828091221==" --===============1304397856828091221== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Nov. 30, 2011, 6:01 p.m., Thomas Baumgart wrote: > > trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb, line 443 > > > > > > Is there a specific reason why you don't add the doc subdirectory f= or stuff fetched from git? The git modules I have checked, have the non-translated documents in the gi= t repo and the directory already added in the CMakeLists.txt. I take it tha= t, that is the "standard" :) So the documentation should actually be built. - K=C3=A5re ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6842/#review10493 ----------------------------------------------------------- On Nov. 29, 2011, 4:42 p.m., K=C3=A5re S=C3=A4rs wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6842/ > ----------------------------------------------------------- > = > (Updated Nov. 29, 2011, 4:42 p.m.) > = > = > Review request for kdelibs and Release Team. > = > = > Description > ------- > = > This patch adds git support to create_tarball.rb in kdesdk. The patch add= s two options to the ini file. The first one (gitModule) indicates that the= module is located in git and the second optional parameter (gitTag) define= s which tag to use for creating the release. (there is no group for kdesdk = or extragear) > = > = > Diffs > ----- > = > trunk/KDE/kdesdk/scripts/createtarball/config.ini 1266277 = > trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb 1266277 = > = > Diff: http://svn.reviewboard.kde.org/r/6842/diff/diff > = > = > Testing > ------- > = > = > Thanks, > = > K=C3=A5re S=C3=A4rs > = > --===============1304397856828091221== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6842/

On November 30th, 2011, 6:01 p.m., Thomas B= aumgart wrote:
= = =
trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb (Diff revision 1)
429
    if appdata["docs&q=
uot;] !=3D "no"
442
    if (appdata["docs"] !=3D "no&q=
uot;) && (<=
/span>!appdata["gitModule&quo=
t;])
Is there =
a specific reason why you don't add the doc subdirectory for stuff fetc=
hed from git?

The git modules I have checked, have the non-translated documents in=
 the git repo and the directory already added in the CMakeLists.txt. I take=
 it that, that is the "standard" :) So the documentation should a=
ctually be built.

- K=C3=A5re

On November 29th, 2011, 4:42 p.m., K=C3=A5re S=C3=A4rs wrote:

Review request for kdelibs and Release Team.

By K=C3=A5re S=C3=A4rs.

Updated Nov. 29, 2011, 4:42 p.m.

Descripti= on

This patch adds git support to create_tarball.rb in kdesdk. =
The patch adds two options to the ini file. The first one (gitModule) indic=
ates that the module is located in git and the second optional parameter (g=
itTag) defines which tag to use for creating the release. (there is no grou=
p for kdesdk or extragear)

Diffs=

trunk/KDE/kdesdk/scripts/createtarball/config.ini (1266277)
trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb (1266277)

--===============1304397856828091221==-- --===============7104204477396596477== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team --===============7104204477396596477==--