[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    D8679: KMail redirect dialogue: Improve layout
From:       Sandro_Knauß <noreply () phabricator ! kde ! org>
Date:       2017-11-06 13:36:35
Message-ID: 20171106133634.26733.25F7B72218913ACF () phabricator ! kde ! org
[Download RAW message or body]

knauss added subscribers: kde-i18n-doc, knauss.
knauss accepted this revision.
knauss added a comment.
This revision is now accepted and ready to land.


  looks fine.

INLINE COMMENTS

> redirectdialog.cpp:154
> mainLayout->setMargin(0);
> -    QLabel *LabelTo = new QLabel(i18n("Select the recipient addresses to \
> redirect:")); +    QLabel *LabelTo = new QLabel(i18n("Select the recipient \
> addresses to redirect to:")); mainLayout->addWidget(LabelTo);

@kde-i18n-doc: a i18n change, after November 16, user visible text changes need \
approval from kde-i18n-doc@kde.org for 17.12

REPOSITORY
  R92 PIM: Common Mail Support

REVISION DETAIL
  https://phabricator.kde.org/D8679

To: marten, #kde_pim, knauss
Cc: knauss, kde-i18n-doc, dvasin, winterz, vkrause, mlaurent, dvratil


[Attachment #3 (unknown)]

<table><tr><td style="">knauss added subscribers: kde-i18n-doc, knauss.<br />knauss \
accepted this revision.<br />knauss added a comment.<br />This revision is now \
accepted and ready to land. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8679" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>looks fine.</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D8679#inline-38118" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">redirectdialog.cpp:154</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">    <span class="n">mainLayout</span><span style="color: \
#aa2211">-&gt;</span><span class="n">setMargin</span><span class="p">(</span><span \
style="color: #601200">0</span><span class="p">);</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span \
class="n">QLabel</span> <span style="color: #aa2211">*</span><span \
class="n">LabelTo</span> <span style="color: #aa2211">=</span> <span style="color: \
#aa4000">new</span> <span class="n">QLabel</span><span class="p">(</span><span \
class="n">i18n</span><span class="p">(</span><span style="color: \
#766510">&quot;Select the recipient addresses to redirect:&quot;</span><span \
class="p">));</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">    <span class="n">QLabel</span> <span style="color: \
#aa2211">*</span><span class="n">LabelTo</span> <span style="color: #aa2211">=</span> \
<span style="color: #aa4000">new</span> <span class="n">QLabel</span><span \
class="p">(</span><span class="n">i18n</span><span class="p">(</span><span \
style="color: #766510">&quot;Select the recipient addresses to redirect<span \
class="bright"> to</span>:&quot;</span><span class="p">));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; ">    <span class="n">mainLayout</span><span \
style="color: #aa2211">-&gt;</span><span class="n">addWidget</span><span \
class="p">(</span><span class="n">LabelTo</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;"><a href="https://phabricator.kde.org/p/kde-i18n-doc/" style="  \
border-color: #f1f7ff;  color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@kde-i18n-doc</a>: a i18n change, \
after November 16, user visible text changes need approval from kde-i18n-doc@kde.org \
for 17.12</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R92 PIM: Common Mail \
Support</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8679" \
rel="noreferrer">https://phabricator.kde.org/D8679</a></div></div><br \
/><div><strong>To: </strong>marten, KDE PIM, knauss<br /><strong>Cc: </strong>knauss, \
kde-i18n-doc, dvasin, winterz, vkrause, mlaurent, dvratil<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]