[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    D8679: KMail redirect dialogue: Improve layout
From:       Jonathan Marten <noreply () phabricator ! kde ! org>
Date:       2017-11-06 12:12:33
Message-ID: differential-rev-PHID-DREV-7kxckndt2nglsg5necch-req () phabricator ! kde ! org
[Download RAW message or body]

marten created this revision.
marten added a reviewer: KDE PIM.
Restricted Application added a project: KDE PIM.

REVISION SUMMARY
  The original layout of the dialogue:
  
  F5478642: kmail-redirectdialogue-BEFORE.png <https://phabricator.kde.org/F5478642>
  
  is missing the default layout spacing between the three address labels and their \
fields, and around the two combo boxes.  
  These changes restore that spacing;
  
  F5478646: kmail-redirectdialogue-AFTER.png <https://phabricator.kde.org/F5478646>
  
  The implementation is slightly complicated because using the default form layout \
spacing would result in double spacing around the address fields, caused by the push \
buttons.  To avoid this, the form layout vertical spacing is set to zero and explicit \
spacing is added around the combo boxes.  
  The focus policy of the RedirectWidget is set so that buddy accelerators work.

TEST PLAN
  Built mailcommon with this change, observed correct appearance and operation of the \
dialogue.

REPOSITORY
  R92 PIM: Common Mail Support

REVISION DETAIL
  https://phabricator.kde.org/D8679

AFFECTED FILES
  src/widgets/redirectdialog.cpp
  src/widgets/redirectwidget.cpp

To: marten, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil


[Attachment #3 (unknown)]

<table><tr><td style="">marten created this revision.<br />marten added a reviewer: \
KDE PIM.<br />Restricted Application added a project: KDE PIM. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8679" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>The original layout of the dialogue:</p>

<p><a href="https://phabricator.kde.org/F5478642" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F5478642: \
kmail-redirectdialogue-BEFORE.png</a></p>

<p>is missing the default layout spacing between the three address labels and their \
fields, and around the two combo boxes.</p>

<p>These changes restore that spacing;</p>

<p><a href="https://phabricator.kde.org/F5478646" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">F5478646: \
kmail-redirectdialogue-AFTER.png</a></p>

<p>The implementation is slightly complicated because using the default form layout \
spacing would result in double spacing around the address fields, caused by the push \
buttons.  To avoid this, the form layout vertical spacing is set to zero and explicit \
spacing is added around the combo boxes.</p>

<p>The focus policy of the RedirectWidget is set so that buddy accelerators \
work.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Built mailcommon \
with this change, observed correct appearance and operation of the \
dialogue.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R92 PIM: \
Common Mail Support</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D8679" \
rel="noreferrer">https://phabricator.kde.org/D8679</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>src/widgets/redirectdialog.cpp<br /> \
src/widgets/redirectwidget.cpp</div></div></div><br /><div><strong>To: \
</strong>marten, KDE PIM<br /><strong>Cc: </strong>dvasin, winterz, vkrause, \
mlaurent, knauss, dvratil<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]