[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 127023: [KFileMetadata] Support Origin Email subject/sender/id
From:       Vishesh Handa <me () vhanda ! in>
Date:       2016-02-15 13:31:51
Message-ID: 20160215133151.26765.67566 () mimi ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127023/#review92404
-----------------------------------------------------------


Fix it, then Ship it!





src/propertyinfo.cpp (line 421)
<https://git.reviewboard.kde.org/r/127023/#comment63024>

    I'm not too keen on indexing this unless there is a clear use case. It just \
increases the size of the index.  
    During the Nepomuk days we used to index and collect way too much information \
with the hope that we would be find amazing creative uses for the data. It did not \
end well.


- Vishesh Handa


On Feb. 9, 2016, 9:09 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127023/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 9:09 p.m.)
> 
> 
> Review request for KDE Frameworks, KDEPIM, Daniel Vrátil, Sebastian Kügler, and \
> Vishesh Handa. 
> 
> Repository: kfilemetadata
> 
> 
> Description
> -------
> 
> This adds support for the user.xdg.origin.email.subject, \
> user.xdg.origin.email.sender, user.xdg.origin.email.message-id xattrs [1] to \
> KFileMetadata. 
> This can (should :P) be populated by KMail when you save an attachment.
> 
> Not too happy about the "displayName" I chose. Also we'll need to figure out what \
> to index and how we can relate this information and present it to the user in a \
> meaningful way. But at least let's collect the information first and then we can \
> think about ways to handle this. 
> [1] https://wiki.freedesktop.org/www/CommonExtendedAttributes/
> 
> 
> Diffs
> -----
> 
> src/properties.h 6ceaca5 
> src/propertyinfo.cpp 4d1fac4 
> src/usermetadata.h 9e10d2a 
> src/usermetadata.cpp 5485d0e 
> 
> Diff: https://git.reviewboard.kde.org/r/127023/diff/
> 
> 
> Testing
> -------
> 
> Not really. Tests pass, though.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]