'Re: [Kde-pim] Review Request 127074: Make stdlib exception include detection work with clang/libc++'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 127074: Make stdlib exception include detection work with clang/libc++
From:       Daniel_Vrátil <dvratil () kde ! org>
Date:       2016-02-15 13:24:06
Message-ID: 20160215132406.26765.65227 () mimi ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127074/#review92402
-----------------------------------------------------------

Ship it!

Looks good, thanks!

- Daniel Vrátil

On Feb. 14, 2016, 6:17 p.m., Armin K. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127074/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2016, 6:17 p.m.)
> 
> 
> Review request for Akonadi and Daniel Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> Currently, akonadi has some code to detect full path to C++ exception include.
> 
> This code doesn't work if -DCMAKE_CXX_COMPILER is set to "clang++ -stdlib=libc++", \
> becaue cmake strips the second parameter, only leaving full path to the compiler. 
> It doesn't even work when I set -DCMAKE_CXX_FLAGS to "-stdlib=libc++" as the cmake \
> module that looks for the include path doesn't use them. Even if I try to use them, \
> clang chokes because there are some flags that shouldn't be passed in combination \
> with -stdlib=libc++ 
> The only sane path is this. If -DCXX_STDLIB is passed to cmake (ie, \
> -DCXX_STDLIB=libc++), the cmake scriptlet only uses that flag. If nothing's passed \
> to the variable, it's ignored. 
> 
> Diffs
> -----
> 
> CMakeLists.txt 05a94d3 
> cmake/modules/FindStdlibInclude.cmake 135e655 
> 
> Diff: https://git.reviewboard.kde.org/r/127074/diff/
> 
> 
> Testing
> -------
> 
> Now builds with both clang++ -stdlib=libc++ and plain ol' g++
> 
> 
> Thanks,
> 
> Armin K.
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread] 