[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 121937: Fix links to files in TNEF attachements with non-asci character
From:       "Allen Winter" <winter () kde ! org>
Date:       2015-01-08 22:02:46
Message-ID: 20150108220246.28638.257 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121937/#review73532
-----------------------------------------------------------


I have no problem with this patch, although a little comment describing why you are \
assigning to QString to remove the non-ascii might be useful.

- Allen Winter


On Jan. 8, 2015, 9:55 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121937/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 9:55 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This patch fixes the generated file links for files in TNEF attachments containing \
> non-ascii-charcters. With this patch, the same file naming scheme is applied as \
> used in KNefParser::extractAttachementTo(...) which first uses att->fileName() and \
> att->file() only as a fallback. The patch contains fixes for all code snippets in \
> KDEPIM using KTNEFParser::extractFileTo(...). 
> 
> Diffs
> -----
> 
> ktnef/ktnefmain.cpp e9d9bef 
> plugins/messageviewer/bodypartformatter/application_ms-tnef.cpp 3ac8bfe 
> 
> Diff: https://git.reviewboard.kde.org/r/121937/diff/
> 
> 
> Testing
> -------
> 
> Tested manually with a TNEF attachement containing German umlauts in file names.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]