[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Review Request 121937: Fix links to files in TNEF attachements with non-asci characters
From:       "Andreas Cord-Landwehr" <cordlandwehr () kde ! org>
Date:       2015-01-08 21:55:21
Message-ID: 20150108215521.28638.25267 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121937/
-----------------------------------------------------------

Review request for KDEPIM and Laurent Montel.


Repository: kdepim


Description
-------

This patch fixes the generated file links for files in TNEF attachments containing \
non-ascii-charcters. With this patch, the same file naming scheme is applied as used \
in KNefParser::extractAttachementTo(...) which first uses att->fileName() and \
att->file() only as a fallback. The patch contains fixes for all code snippets in \
KDEPIM using KTNEFParser::extractFileTo(...).


Diffs
-----

  ktnef/ktnefmain.cpp e9d9bef 
  plugins/messageviewer/bodypartformatter/application_ms-tnef.cpp 3ac8bfe 

Diff: https://git.reviewboard.kde.org/r/121937/diff/


Testing
-------

Tested manually with a TNEF attachement containing German umlauts in file names.


Thanks,

Andreas Cord-Landwehr

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]