[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 117133: Make ItemSync::Private inherit from JobPrivate.
From:       Dan_Vrátil <dvratil () redhat ! com>
Date:       2014-03-28 18:08:03
Message-ID: 20140328180803.10710.12939 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117133/#review54480
-----------------------------------------------------------

Ship it!


Remember to adapt coding style when merging to master.

- Dan Vrátil


On March 28, 2014, 12:33 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117133/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 12:33 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Make ItemSync::Private inherit from JobPrivate.
> 
> i.e. port it to Q_Q and Q_D. This makes it match ItemFetchJob, and
> makes it possible to (in a later commit) reimplement the virtual method
> JobPrivate::jobDebuggingString().
> 
> 
> Diffs
> -----
> 
> akonadi/itemsync.h 037f2b25207f789942cdb27aaebd9f4306bc9ddb 
> akonadi/itemsync.cpp 05ee3d04a5b94c85abcab27ebc638e57b6a63d41 
> 
> Diff: https://git.reviewboard.kde.org/r/117133/diff/
> 
> 
> Testing
> -------
> 
> Recompiled, restarted kmail, no crash, email sync appears to work. Not that I \
> really know when ItemSync is actually triggered (adding a debug string is exactly \
> for that: to find out more about when/how/for what it gets triggered). 
> 
> Thanks,
> 
> David Faure
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]