[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Review Request 117144: Switch ServerManager to Broken state immediately when o.f.Akonadi.C
From:       Dan_Vrátil <dvratil () redhat ! com>
Date:       2014-03-28 17:52:39
Message-ID: 20140328175239.10710.37053 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117144/
-----------------------------------------------------------

Review request for Akonadi.


Repository: kdepimlibs


Description
-------

When Akonadi is unable to start (because it can't start the DB process for example), \
it will terminate immediately. The current implementation of ServerManager has a 30 \
seconds timeout before it goes to 'Broken' state.

This patch adds a new check that will switch to Broken state immediately when \
org.freedesktop.Akonadi.Control.Lock disappears from bus. This service is owned by \
akonadi_control and when akonadi_control quits, it can only be because Akonadi has \
stopped (== failed to start), so when this happens in "Startup" state, we can safely \
assume, that Akonadi failed to start and we should go to Broken state.


Diffs
-----

  akonadi/servermanager.cpp 64ac5e9 
  akonadi/session.cpp 0224c02 

Diff: https://git.reviewboard.kde.org/r/117144/diff/


Testing
-------

Stopped Akonadi, broke it (so that it does not start), started KMail, got "Akonadi is \
inoperational" immediately instead of 30 seconds of "Starting up the PIM service...".


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]