[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Akonadi Commandline Interface Project
From:       Bhaskar Kandiyal <bkandiyal () gmail ! com>
Date:       2014-03-03 11:44:53
Message-ID: 53146865.4080102 () gmail ! com
[Download RAW message or body]

On Monday 03 March 2014 03:21 AM, Kevin Krammer wrote:
> On Monday, 2014-03-03, 02:24:10, Bhaskar Kandiyal wrote:
>> Hi!
>>
>> I've made a few changes to the application [1], mainly:
>>
>> * Moved QCoreApplication initialization to main() - Should I send a
>> patch for review?
> 
> I would suggest to also rename CommandRunner::exec() to 
> CommandRunner::start(), it no longer has exec() behavior.
> 
> Also the main idea of the move was to create the application object before the 
> runner.
> 
Ah, I kind of missed the point there, sorry! I've made the changes now :)

Cheers,
Bhaskar Kandiyal
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]