[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Akonadi Commandline Interface Project
From:       Kevin Krammer <krammer () kde ! org>
Date:       2014-03-02 21:51:05
Message-ID: 17648691.cggH83lTOh () persephone
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday, 2014-03-03, 02:24:10, Bhaskar Kandiyal wrote:
> Hi!
> 
> I've made a few changes to the application [1], mainly:
> 
> * Moved QCoreApplication initialization to main() - Should I send a
> patch for review?

I would suggest to also rename CommandRunner::exec() to 
CommandRunner::start(), it no longer has exec() behavior.

Also the main idea of the move was to create the application object before the 
runner.

Almost everything in the command runner constructor could be moved to start.
Maybe have a CommandFactory member and initialize it, but creation of command 
and init can be done in start(), so start can return error whenever it needs, 
without having to call exit itself.

Cheers,
Kevin
-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring

["signature.asc" (application/pgp-signature)]

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread]